GH-43796: [C++] Indent preprocessor directives #43798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
requested review from
kevingurney,
sgilmore10,
wgtmac,
lidavidm and
westonpace
as code owners
|
|
github-actions
bot
added
Component: Parquet
Component: C++
Component: Python
Component: FlightRPC
Component: Gandiva
Component: MATLAB
awaiting committer review
lidavidm
approved these changes
Aug 23, 2024
github-actions
bot
added
awaiting merge
sgilmore10
approved these changes
Aug 23, 2024
zanmato1984
approved these changes
Aug 28, 2024
kou
changed the title
|
It makes sense. I've chanted the title as you suggested. |
|
(I'll fix the lint failure later.) |
|
The discussion thread: https://lists.apache.org/thread/gb2dpphhwz358zfb03k9ly18gs92rzdr |
kou
force-pushed
the
cpp-preprocessor-indent
branch
from
36068da to
29fb2a1
Compare
|
No objection in the discussion thread. |
|
I'll merge this. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Sep 6, 2024
### Rationale for this change This is for easy to read. FYI: Google C++ style guide doesn't require indent in preprocessor directives nor deny it: https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives ```cpp // Good - directives at beginning of line if (lopsided_score) { #if DISASTER_PENDING // Correct -- Starts at beginning of line DropEverything(); # if NOTIFY // OK but not required -- Spaces after # NotifyClient(); # endif #endif BackToNormal(); } ``` ### What changes are included in this PR? * Add clang-format configurations for preprocessor directives indentation * Apply these configurations ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#43796 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5ad0b3e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
khwilson
pushed a commit
to khwilson/arrow
that referenced
this pull request
Sep 14, 2024
### Rationale for this change This is for easy to read. FYI: Google C++ style guide doesn't require indent in preprocessor directives nor deny it: https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives ```cpp // Good - directives at beginning of line if (lopsided_score) { #if DISASTER_PENDING // Correct -- Starts at beginning of line DropEverything(); # if NOTIFY // OK but not required -- Spaces after # NotifyClient(); # endif #endif BackToNormal(); } ``` ### What changes are included in this PR? * Add clang-format configurations for preprocessor directives indentation * Apply these configurations ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#43796 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is for easy to read.
FYI: Google C++ style guide doesn't require indent in preprocessor directives nor deny it:
https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives
What changes are included in this PR?
Are these changes tested?
Yes.
Are there any user-facing changes?
No.