-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python][CI] Substrait nightly job is failing due to wrong invocation of substrait consumer-testing #45159
Comments
This is not the first time the job fails.
Should we keep maintaining it? |
cc @westonpace |
@jorisvandenbossche @pitrou @kou this job has been failing for 5 weeks and it does not seem to be maintained. Should we propose to remove it? I don't think we ever detected a failure on the Arrow side on this job but always have found it failing due to changes around |
+1 for removal. Another idea: How about bundling a subset of consumer-testing and updating it on our own time? It seems that we only uses arrow/ci/scripts/integration_substrait.sh Line 31 in ef00568
|
I am going to remove the job. It seems those test files were removed from upstream and I am unsure how we are supposed to be testing at the moment: |
…tion job (#45463) ### Rationale for this change The job has been failing for the last two months due to upstream refactoring. I opened an issue upstream but we didn't got any response: - substrait-io/consumer-testing#196 Based on the following substrait consumer-testing PR there was a big refactor which removed the files that we were invoking on our tests: - substrait-io/consumer-testing#162 I asked on the corresponding issue ~3 weeks ago for feedback on the removal and as there's no opposition I think we should remove this unmaintained job. ### What changes are included in this PR? Remove extremely coupled `substrait-io/consumer-testing` job. ### Are these changes tested? No ### Are there any user-facing changes? No * GitHub Issue: #45159 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
Issue resolved by pull request 45463 |
Describe the bug, including details regarding any error messages, version, and platform.
The integration test for substrait (test-conda-python-3.10-substrait) has been failing for the last 21 days with:
The execution fails when running:
Component(s)
Continuous Integration, Python
The text was updated successfully, but these errors were encountered: