Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python][CI] Substrait nightly job is failing due to wrong invocation of substrait consumer-testing #45159

Closed
raulcd opened this issue Jan 3, 2025 · 6 comments

Comments

@raulcd
Copy link
Member

raulcd commented Jan 3, 2025

Describe the bug, including details regarding any error messages, version, and platform.

The integration test for substrait (test-conda-python-3.10-substrait) has been failing for the last 21 days with:

 Substrait Integration Tests
Validating imports
Executing pytest
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: --producer isthmus --consumer acero
  inifile: /consumer-testing/pytest.ini
  rootdir: /consumer-testing

The execution fails when running:

pytest -r s substrait_consumer/tests/functional/extension_functions/test_boolean_functions.py --producer isthmus --consumer acero

Component(s)

Continuous Integration, Python

@raulcd
Copy link
Member Author

raulcd commented Jan 3, 2025

cc @westonpace

@raulcd
Copy link
Member Author

raulcd commented Jan 14, 2025

@jorisvandenbossche @pitrou @kou this job has been failing for 5 weeks and it does not seem to be maintained. Should we propose to remove it? I don't think we ever detected a failure on the Arrow side on this job but always have found it failing due to changes around substrait-consumer. I've opened an issue on the substrait repo and suggested the removal.

@kou
Copy link
Member

kou commented Jan 14, 2025

+1 for removal.

Another idea: How about bundling a subset of consumer-testing and updating it on our own time?

It seems that we only uses test_boolean_functions.py:

pytest -r s substrait_consumer/tests/functional/extension_functions/test_boolean_functions.py --producer isthmus --consumer acero

@raulcd
Copy link
Member Author

raulcd commented Feb 7, 2025

I am going to remove the job. It seems those test files were removed from upstream and I am unsure how we are supposed to be testing at the moment:
substrait-io/consumer-testing@b9a2c2d#diff-3b4dab90628ffb3cc9cc2d1340fac6a507e7ed9a2a0e4fa2b6e81b9be54e4547
I tried to navigate the related PRs but it's unclear to me.

raulcd added a commit to raulcd/arrow that referenced this issue Feb 7, 2025
raulcd added a commit that referenced this issue Feb 13, 2025
…tion job (#45463)

### Rationale for this change

The job has been failing for the last two months due to upstream refactoring. I opened an issue upstream but we didn't got any response:
- substrait-io/consumer-testing#196

Based on the following substrait consumer-testing PR there was a big refactor which removed the files that we were invoking on our tests:
- substrait-io/consumer-testing#162

I asked on the corresponding issue ~3 weeks ago for feedback on the removal and as there's no opposition I think we should remove this unmaintained job.

### What changes are included in this PR?

Remove extremely coupled `substrait-io/consumer-testing` job.

### Are these changes tested?

No

### Are there any user-facing changes?

No
* GitHub Issue: #45159

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@raulcd raulcd added this to the 20.0.0 milestone Feb 13, 2025
@raulcd
Copy link
Member Author

raulcd commented Feb 13, 2025

Issue resolved by pull request 45463
#45463

@raulcd raulcd closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants