-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
GH-45295: [Python][CI] Make download_tzdata_on_windows more robust an…
…d use tzdata package for tzinfo database on Windows for ORC (#45425) ### Rationale for this change We have two Windows issues and this PR is addressing both: 1. PyArrow's `download_tzdata_on_windows` can fail due to TLS issues in certain CI environments. 2. The Python wheel test infrastructure needs a tzinfo database for ORC and the automation fetching that started failing because the URL was made invalid upstream. These two issues are being solved in one PR simply because they appeared together during the 19.0.1 release process but they're separate. ### What changes are included in this PR? 1. Makes `download_tzdata_on_windows` more robust to TLS errors by attempting to use `requests` if it's available and falling back to urllib otherwise. 2. Switches our Windows wheel test infrastructure to grab a tzinfo database from the tzdata package on PyPi instead of from a mirror URL. This should be much more stable for us over time. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #45295 Lead-authored-by: Bryce Mecum <[email protected]> Co-authored-by: Joris Van den Bossche <[email protected]> Signed-off-by: Bryce Mecum <[email protected]>
- Loading branch information
1 parent
f1961ec
commit f6e2cbe
Showing
4 changed files
with
46 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters