Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Release] Update versions for 15.0.2 #346

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

amoeba
Copy link
Member

@amoeba amoeba commented Mar 21, 2024

No description provided.

@amoeba amoeba requested a review from raulcd March 21, 2024 15:08
@raulcd
Copy link
Member

raulcd commented Mar 21, 2024

I am not entirely sure why the Java test for flight is failing with:

Exception java.lang.NoClassDefFoundError: io/grpc/BindableService
      at FlightServer.builder (FlightServer.java:169)
      at (#39:4)
Caused by: java.lang.ClassNotFoundException: io.grpc.BindableService
      at BuiltinClassLoader.loadClass (BuiltinClassLoader.java:641)
      at ClassLoaders$AppClassLoader.loadClass (ClassLoaders.java:188)
      at ClassLoader.loadClass (ClassLoader.java:521)

@amoeba
Copy link
Member Author

amoeba commented Mar 21, 2024

I'll look into it later today and report back.

@amoeba
Copy link
Member Author

amoeba commented Mar 22, 2024

I wasn't able to reproduce the error locally, though I do get a failure in the avro cookbook:

avro.rst failure
Document: avro
--------------
Error:
package org.apache.arrow.adapter.avro does not exist
import org.apache.arrow.adapter.avro.AvroToArrow;
       ^---------------------------------------^
Error:
package org.apache.arrow.adapter.avro does not exist
import org.apache.arrow.adapter.avro.AvroToArrowConfig;
       ^---------------------------------------------^
Error:
package org.apache.arrow.adapter.avro does not exist
import org.apache.arrow.adapter.avro.AvroToArrowConfigBuilder;
       ^----------------------------------------------------^
Error:
package org.apache.arrow.adapter.avro does not exist
import org.apache.arrow.adapter.avro.AvroToArrowVectorIterator;
       ^-----------------------------------------------------^
Error:
cannot find symbol
  symbol:   class AvroToArrowConfig
        AvroToArrowConfig config = new AvroToArrowConfigBuilder(allocator).build();
        ^---------------^
Error:
cannot find symbol
  symbol:   class AvroToArrowConfigBuilder
        AvroToArrowConfig config = new AvroToArrowConfigBuilder(allocator).build();
                                       ^----------------------^
Error:
cannot find symbol
  symbol:   class AvroToArrowVectorIterator
        try (AvroToArrowVectorIterator avroToArrowVectorIterator = AvroToArrow.avroToArrowIterator(schema, decoder, config)) {
             ^-----------------------^
Error:
cannot find symbol
  symbol:   variable AvroToArrow
        try (AvroToArrowVectorIterator avroToArrowVectorIterator = AvroToArrow.avroToArrowIterator(schema, decoder, config)) {
                                                                   ^---------^
-> **********************************************************************
File "avro.rst", line 65, in default
Failed example:
    import org.apache.arrow.adapter.avro.AvroToArrow;
    import org.apache.arrow.adapter.avro.AvroToArrowConfig;
    import org.apache.arrow.adapter.avro.AvroToArrowConfigBuilder;
    import org.apache.arrow.adapter.avro.AvroToArrowVectorIterator;
    import org.apache.arrow.memory.BufferAllocator;
    import org.apache.arrow.memory.RootAllocator;
    import org.apache.arrow.vector.VectorSchemaRoot;
    import org.apache.avro.Schema;
    import org.apache.avro.io.BinaryDecoder;
    import org.apache.avro.io.DecoderFactory;

    import java.io.File;
    import java.io.FileInputStream;
    import java.io.FileNotFoundException;
    import java.io.IOException;

    try {
        BinaryDecoder decoder = new DecoderFactory().binaryDecoder(new FileInputStream("./thirdpartydeps/avro/users.avro"), null);
        Schema schema = new Schema.Parser().parse(new File("./thirdpartydeps/avro/user.avsc"));
        try (BufferAllocator allocator = new RootAllocator()) {
            AvroToArrowConfig config = new AvroToArrowConfigBuilder(allocator).build();
            try (AvroToArrowVectorIterator avroToArrowVectorIterator = AvroToArrow.avroToArrowIterator(schema, decoder, config)) {
                while(avroToArrowVectorIterator.hasNext()) {
                    try (VectorSchemaRoot root = avroToArrowVectorIterator.next()) {
                        System.out.print(root.contentToTSVString());
                    }
                }
            }
        }
    } catch (Exception e) {
        e.printStackTrace();
    }
Expected:
    name    favorite_number    favorite_color
    Alyssa    256    null
    Ben    7    red
Got:

I'm going to re-run the failed jobs to see if it's just a transient issue and then see about the Avro issue.

@amoeba
Copy link
Member Author

amoeba commented Apr 10, 2024

Hey @raulcd, I forgot about this but took another look today. I re-ran this patch locally and it works fine now? I'm not sure what might have changed.

I am able to reproduce the above grpc error on 16.0.0-SNAPSHOT so I can look into that elsewhere. Otherwise, I think this is ready for a merge.

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and CI is passing now.

@raulcd raulcd merged commit b50cfa0 into apache:main Apr 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants