Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set default value of ssl_trusted_certificate to system #11993

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

feat: set default value of ssl_trusted_certificate to system #11993

wants to merge 9 commits into from
+6 −5

Conversation

Revolyssup
Copy link
Contributor

@Revolyssup Revolyssup commented Feb 25, 2025 •
edited by nic-6443
Loading

Description

When testing AI plugins, we found that ssl_trusted_certificate should be set to system, otherwise APISIX will continuously report errors when accessing external AI services.

unable to get local issuer certificate

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Feb 25, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 25, 2025
nic-6443
nic-6443 previously approved these changes Feb 25, 2025
View reviewed changes
@nic-6443 nic-6443 changed the title feat: use "system" as default when ssl_trusted_certificate not passed feat: set default value of ssl_trusted_certificate to system Feb 25, 2025
@nic-6443 nic-6443 changed the title feat: set default value of ssl_trusted_certificate to system feat: set default value of ssl_trusted_certificate to system Feb 25, 2025
nic-6443
nic-6443 previously approved these changes Feb 25, 2025
View reviewed changes
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 25, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Feb 25, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic-6443 nic-6443 nic-6443 left review comments

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Revolyssup @nic-6443 @shreemaan-abhishek