-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purge existing SLA implementation #42285
Purge existing SLA implementation #42285
Conversation
5560ba3
to
f62927e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are is an SLA related configuration that I don't see removed in this PR?
https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#check-slas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, added the breaking label, now CI test fails with exactly the comment I wanted to make - please add a newsfragment for the breaking change
Otherwise - looks good for me.
I am a bit surprised that the carve-out of SLA just gains 1k LoC
Yeah. It's an odd one. I really expected this to be a much larger surgery with tendrils all over the place. It wasn't as bad as I had feared; 28 files is pretty broad but a solid chunk of them are docs pages which just linked back tot he SLA concept page.
I should have known to do that, sorry. I'll add it.
Yeah, I may have missed that one. I'll make another pass and see what I can find related to "check_slas" and prune it.
I'll come up with something. |
224fe96
to
25e1a7f
Compare
SLA will be reimplemented in either 3.0 or 3.1
As discussed in the Airflow 3.0 dev calls, the first step for the new SLA system is stripping the existing implementation out.
I did this PR in multiple commits to try to make it more transparent. In this PR: