Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove hull.js package and embed its core source code into g6 #6805

Open
wants to merge 2 commits into
base: v5
Choose a base branch
from

Conversation

zhongyunWan
Copy link
Contributor

remove hull.js package and embed its core source code into g6, The changes are as follows.

  1. put all the source files under plugins/hull
  2. all the JavaScript files are mapped to TypeScript files, and the naming has been optimized.
  3. modify the eslintrc.ts file and the jest.config.js file to ignore the source code of hull.

Copy link

Walkthrough

This PR removes the hull.js package and integrates its core source code directly into the G6 project. The source files are now located under plugins/hull, converted from JavaScript to TypeScript, and the ESLint and Jest configurations have been updated to ignore these files.

Changes

Files Summary
.eslintrc.js, jest.config.js Updated to ignore hull source code.
packages/g6/package.json Removed hull.js dependency.
packages/g6/src/plugins/hull/format.ts, grid_handle.ts, hull.ts, index.ts, monotone-convex-hull-2d.ts, robust-orientation.ts, robust-scale.ts, robust-segment-intersect.ts, robust-subtract.ts, robust-sum.ts, two-product.ts, two-sum.ts Added new TypeScript files for hull functionality.

@zhongyunWan
Copy link
Contributor Author

zhongyunWan commented Feb 25, 2025

resolve this problem([Bug]: hull.js Code Injection Vulnerability #6605

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant