Fix the issue of mouse coordinates being misaligned when hovering ove… #6782
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r nodes after adding an edge with a custom node type set to HTML.
WalkthroughThis pull request addresses an issue with mouse coordinates being misaligned when hovering over custom nodes in HTML/React format during the CreateEdge interaction. The fix involves blocking function handling during the event bubbling and capturing phases to prevent erratic edge pointer drift. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
|
There are two test cases that have failed, you may need to perform a fix https://github.com/antvis/G6/actions/runs/13386208077/job/37451872733?pr=6782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a custom node (in HTML/React format) with the CreateEdge interaction, if the mouse hovers over the custom node, event bubbling and event capturing will be triggered because it is an HTML component. The obtained mouse positioning data will have issues, causing the edge pointer to drift erratically.
So it is necessary to block the function handling during the bubbling and capturing phases.