Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top missing antlr4 headers inside impl. #4793

Merged
merged 9 commits into from
Mar 9, 2025

Conversation

hzeller
Copy link
Contributor

@hzeller hzeller commented Mar 9, 2025

One commit per header for easier review.

Done semi-automatically by taking the output of clang-tidy's misc-include-cleaner reports and inserting them where needed.

~/src/henner-tools/dev-tools/insert-header.cc 'tree/ParseTreeType.h' $(grep "no header providing.*misc-include-cleaner" Cpp_clang-tidy.out | awk -F: '/^runtime\/.*"antlr4::tree::ParseTreeType"/ { print $1}' | sort -u)

This is not done for all missing headers yet, some of the remaining reports point to cyclic dependencies that now work because everyone sees the forward declarations support/Declarations.h. My goal is minimize the reliance on these forward declarations and reach a good IWYU situation for a clear view of the internal dependencies.

Anyway, here a first round.

@hzeller
Copy link
Contributor Author

hzeller commented Mar 9, 2025

FYI @parrt

@parrt parrt merged commit ec1b5f3 into antlr:dev Mar 9, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants