Add top missing antlr4 headers inside impl. #4793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One commit per header for easier review.
Done semi-automatically by taking the output of
clang-tidy
'smisc-include-cleaner
reports and inserting them where needed.This is not done for all missing headers yet, some of the remaining reports point to cyclic dependencies that now work because everyone sees the forward declarations
support/Declarations.h
. My goal is minimize the reliance on these forward declarations and reach a goodIWYU
situation for a clear view of the internal dependencies.Anyway, here a first round.