Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple missing standard headers #4791

Merged
merged 10 commits into from
Mar 9, 2025

Conversation

hzeller
Copy link
Contributor

@hzeller hzeller commented Mar 9, 2025

One commit per header for easier review.

Done half-automatically by running clang-tidy, then using a little script that inserts the header

~/bin/insert-header '<limits>' $(grep "no header providing.*misc-include-cleaner" Cpp_clang-tidy.out | awk -F: '/^runtime\/.*"std::numeric_limits"/ { print $1}' | sort -u)

Overall, this reduced the amount of misc-include-cleaner warnings in the runtime from 1923 downto 1192. More work to do, but already better :)

@hzeller
Copy link
Contributor Author

hzeller commented Mar 9, 2025

FYI @parrt

@parrt parrt merged commit af7edc5 into antlr:dev Mar 9, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants