Use 'override' in virtual methods of derived classes. #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and clean up duplicates where a method is marked `virtual` _and_ `override` (`override` implies `virtual). Use of `override` informs the developer reading the code and reduces mistakes (e.g. accidentally messing up a signature while overridding). Signed-off-by: Henner Zeller <[email protected]>
hzeller
force-pushed
the
feature-20250308-use-override
branch
from
4337ea6 to
ef07d6a
Compare
|
FYI @parrt |
|
hiya. gosh, that's a lot of changes, adding virtual everywhere etc! Is it worth the risk of such a big change? I will defer to your experience. |
|
there is no risk. Also, if you noticced, most of the change is just removing the superfluous |
|
or to put it this way: the code is identical to the previous one for all intents and purposes, just more readable. |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and clean up duplicates where a method is marked
virtualandoverride(overrideimplies `virtual).Use of
overrideinforms the developer reading the code and reduces mistakes (e.g. accidentally messing up a signature while overridding).