Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed js response output #18

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

bakhangildin
Copy link
Contributor

I figured out following thing:
String.fromCharCode(0) returns "\x00", but putstr and console.log borks there and not printing this symbol.
So i decided to hex encode everything

Also I made some investigation:
Implementation of putstr of spidermonkey https://github.com/ricardoquesada/Spidermonkey/blob/master/js/src/shell/js.cpp#L1555
I guess the thing that breaks everything on line 1561:

1561 if (!str)
1562     return false;

@bakhangildin bakhangildin changed the title Somehow cracked js with hex encoding values Fixed js response output Jan 10, 2024
@anthdm anthdm merged commit 938c906 into anthdm:js-resp Jan 10, 2024
2 checks passed
@bakhangildin bakhangildin deleted the js-resp-try-fix branch January 10, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants