-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: requirements #2072
base: master
Are you sure you want to change the base?
fix: requirements #2072
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2072 +/- ##
=======================================
Coverage 86.52% 86.52%
=======================================
Files 90 90
Lines 10233 10233
=======================================
Hits 8854 8854
Misses 1379 1379 |
@@ -1,4 +1,3 @@ | |||
black==25.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jorgepiloto, again, this is used in the ci/code_generation.py
script. We cannot remove it here or we need to also modify the file mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PProfizi, I do not see the tool being used in the script you refer to https://github.com/ansys/pydpf-core/blob/master/.ci/code_generation.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgepiloto sorry I meant here, which is what runs when we call code_generation.py
. @moe-ad FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We basically use it to reformat some code we autogenerate based on a template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot remove black
directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PProfizi why are we not removing black? Maybe we can add a comment to the requirements file to ensure everyone that comes across this knows why we are keeping it?
@jorgepiloto see #2064. |
Removes empty file and
black
as a dependency in favor of Ruff.