Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requirements #2072

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: requirements #2072

wants to merge 2 commits into from

Conversation

jorgepiloto
Copy link
Member

Removes empty file and black as a dependency in favor of Ruff.

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.52%. Comparing base (6729aef) to head (1ce2b16).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2072   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files          90       90           
  Lines       10233    10233           
=======================================
  Hits         8854     8854           
  Misses       1379     1379           

@@ -1,4 +1,3 @@
black==25.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jorgepiloto, again, this is used in the ci/code_generation.py script. We cannot remove it here or we need to also modify the file mentioned.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PProfizi, I do not see the tool being used in the script you refer to https://github.com/ansys/pydpf-core/blob/master/.ci/code_generation.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgepiloto sorry I meant here, which is what runs when we call code_generation.py. @moe-ad FYI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We basically use it to reformat some code we autogenerate based on a template.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation, @PProfizi. @moe-ad, what do you think it is possible to explore Ruff's API for this? I am not sure if this tool has an API for Python. If it had, we could completely drop black.

Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot remove black directly.

moe-ad
moe-ad previously approved these changes Feb 11, 2025
Copy link
Contributor

@moe-ad moe-ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi why are we not removing black? Maybe we can add a comment to the requirements file to ensure everyone that comes across this knows why we are keeping it?

@moe-ad moe-ad dismissed their stale review February 11, 2025 10:18

I missed Paul's comment.

@moe-ad
Copy link
Contributor

moe-ad commented Feb 11, 2025

@jorgepiloto see #2064.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants