Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Enhance native API coverage common.py #5757

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

tizianrot
Copy link
Contributor

Description

  • move add-trace-characteristics to common.py
  • add export_table_to_file to common.py (Native API ExportTableToFile in ReportSetup)

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@tizianrot tizianrot requested a review from gmalinve February 11, 2025 09:00
@tizianrot tizianrot self-assigned this Feb 11, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 23.80952% with 16 lines in your changes missing coverage. Please review.

Project coverage is 40.18%. Comparing base (74863ab) to head (97a5c4c).

❌ Your patch check has failed because the patch coverage (23.80%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5757       +/-   ##
===========================================
- Coverage   84.92%   40.18%   -44.75%     
===========================================
  Files         161      161               
  Lines       62107    62112        +5     
===========================================
- Hits        52745    24957    -27788     
- Misses       9362    37155    +27793     

@gmalinve gmalinve marked this pull request as ready for review February 28, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend add_trace_characteristics and export legend capabilities to Maxwell Reports
4 participants