-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: enable harmonic force #5440
Draft
anur7
wants to merge
34
commits into
main
Choose a base branch
from
feat/enable-harmonic-force
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
58a68ec
FEAT: added missing input parameters (issue #4779)
anur7 64f8ea4
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 ac4ca86
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 3078699
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 7f4c6b0
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 bf8c9e9
FEAT: implemented method for Eddy Current solver (issue #4779)
anur7 d69ab75
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 b2fd29c
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 c869b5c
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 3b32bd9
FEAT:minor improvement
anur7 e6523ca
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 cc25c01
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 598a53b
FEAT:improvement for transient solver
anur7 6dbd081
FEAT: some docstring improvements
anur7 e06dbe4
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 fe0157d
FEAT: some implementation improvements
anur7 1e93929
FEAT:minor improvement
anur7 cd0ad85
FEAT:minor improvement
anur7 aa94b3c
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 3d07454
doc improved, added example
anur7 31e2b6c
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 ceee2bf
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 e4c83f7
improved implementation and UT
anur7 1f07f26
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 c1364de
substituted "self.solution_type = None" with "pass" as it was before
anur7 db81c2e
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
gmalinve ea81b39
fix test
gmalinve 45c5256
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 c3de440
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 41d8fcd
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 ed17fca
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 b6d4eb7
Merge branch 'refs/heads/main' into feat/enable-harmonic-force
anur7 c636463
improved unit test for enable harmonic force method, made independent…
anur7 db146d9
unit test
anur7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anur7 this part is very confusing. I'd simplify it. I also add an extra check on 2d and transient because use_number_of_cycles_from_stop_time and use_number_of_cycles_for_stop_time can be True in 3d Transient and Transient Aphi designs.
But this part has to be reviewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmalinve if I'm not wrong the Maxwell project used in UT contains only a transient 3d design. To increase the code coverage we need also a 2d design for testing.