Rebase #1
Open
Rebase #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> [!IMPORTANT] > Merging this pull request will create this release ## Fixes - allow required fields list to be specified as empty (openapi-generators#651) (openapi-generators#1149) - import cast for required const properties, since it's used in the template (openapi-generators#1153) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
…s#1160) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [typer](https://redirect.github.com/fastapi/typer) ([changelog](https://typer.tiangolo.com/release-notes/)) | `>0.6,<0.13` -> `>0.6,<0.14` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastapi/typer (typer)</summary> ### [`v0.13.0`](https://redirect.github.com/fastapi/typer/releases/tag/0.13.0) [Compare Source](https://redirect.github.com/fastapi/typer/compare/0.12.5...0.13.0) ##### Features - ✨ Handle `KeyboardInterrupt` separately from other exceptions. PR [#​1039](https://redirect.github.com/fastapi/typer/pull/1039) by [@​patrick91](https://redirect.github.com/patrick91). - ✨ Update `launch` to not print anything when opening urls. PR [#​1035](https://redirect.github.com/fastapi/typer/pull/1035) by [@​patrick91](https://redirect.github.com/patrick91). - ✨ Show help items in order of definition. PR [#​944](https://redirect.github.com/fastapi/typer/pull/944) by [@​svlandeg](https://redirect.github.com/svlandeg). ##### Fixes - 🐛 Fix equality check for custom classes. PR [#​979](https://redirect.github.com/fastapi/typer/pull/979) by [@​AryazE](https://redirect.github.com/AryazE). - 🐛 Allow colon in zsh autocomplete values and descriptions. PR [#​988](https://redirect.github.com/fastapi/typer/pull/988) by [@​snapbug](https://redirect.github.com/snapbug). ##### Refactors - 🗑️ Deprecate support for `is_flag` and `flag_value` parameters. PR [#​987](https://redirect.github.com/fastapi/typer/pull/987) by [@​svlandeg](https://redirect.github.com/svlandeg). - 🔥 Remove unused functionality from `_typing.py` file. PR [#​805](https://redirect.github.com/fastapi/typer/pull/805) by [@​ivantodorovich](https://redirect.github.com/ivantodorovich). - ✏️ Fix typo in function name `_make_rich_text`. PR [#​959](https://redirect.github.com/fastapi/typer/pull/959) by [@​svlandeg](https://redirect.github.com/svlandeg). ##### Internal - ✅ Only run completion installation tests when the env var `_TYPER_RUN_INSTALL_COMPLETION_TESTS` is set. PR [#​995](https://redirect.github.com/fastapi/typer/pull/995) by [@​svlandeg](https://redirect.github.com/svlandeg). - 📝 Update the docstring of the `_make_rich_text` method. PR [#​972](https://redirect.github.com/fastapi/typer/pull/972) by [@​svlandeg](https://redirect.github.com/svlandeg). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​1040](https://redirect.github.com/fastapi/typer/pull/1040) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump mkdocs-material from 9.5.42 to 9.5.44. PR [#​1042](https://redirect.github.com/fastapi/typer/pull/1042) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump ruff from 0.7.1 to 0.7.2. PR [#​1038](https://redirect.github.com/fastapi/typer/pull/1038) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-macros-plugin from 1.3.6 to 1.3.7. PR [#​1031](https://redirect.github.com/fastapi/typer/pull/1031) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​1032](https://redirect.github.com/fastapi/typer/pull/1032) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump ruff from 0.7.0 to 0.7.1. PR [#​1029](https://redirect.github.com/fastapi/typer/pull/1029) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump pillow from 10.4.0 to 11.0.0. PR [#​1023](https://redirect.github.com/fastapi/typer/pull/1023) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-material from 9.5.35 to 9.5.42. PR [#​1027](https://redirect.github.com/fastapi/typer/pull/1027) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump ruff from 0.6.5 to 0.7.0. PR [#​1026](https://redirect.github.com/fastapi/typer/pull/1026) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-macros-plugin from 1.2.0 to 1.3.6. PR [#​1025](https://redirect.github.com/fastapi/typer/pull/1025) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Update pre-commit requirement from <4.0.0,>=2.17.0 to >=2.17.0,<5.0.0. PR [#​1012](https://redirect.github.com/fastapi/typer/pull/1012) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump pypa/gh-action-pypi-publish from 1.10.1 to 1.10.3. PR [#​1009](https://redirect.github.com/fastapi/typer/pull/1009) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​1001](https://redirect.github.com/fastapi/typer/pull/1001) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - 👷 Update Deploy docs CI to use uv. PR [#​1021](https://redirect.github.com/fastapi/typer/pull/1021) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Fix smokeshow, checkout files on CI. PR [#​1020](https://redirect.github.com/fastapi/typer/pull/1020) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Use uv in CI. PR [#​1019](https://redirect.github.com/fastapi/typer/pull/1019) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Update `labeler.yml`. PR [#​1014](https://redirect.github.com/fastapi/typer/pull/1014) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Update worfkow deploy-docs-notify URL. PR [#​1011](https://redirect.github.com/fastapi/typer/pull/1011) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Upgrade Cloudflare GitHub Action. PR [#​1010](https://redirect.github.com/fastapi/typer/pull/1010) by [@​tiangolo](https://redirect.github.com/tiangolo). - ⬆ Bump mkdocs-macros-plugin from 1.0.5 to 1.2.0. PR [#​992](https://redirect.github.com/fastapi/typer/pull/992) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump ruff from 0.6.4 to 0.6.5. PR [#​991](https://redirect.github.com/fastapi/typer/pull/991) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-material from 9.5.34 to 9.5.35. PR [#​996](https://redirect.github.com/fastapi/typer/pull/996) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​993](https://redirect.github.com/fastapi/typer/pull/993) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​982](https://redirect.github.com/fastapi/typer/pull/982) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump tiangolo/issue-manager from 0.5.0 to 0.5.1. PR [#​980](https://redirect.github.com/fastapi/typer/pull/980) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - 👷 Update `issue-manager.yml`. PR [#​978](https://redirect.github.com/fastapi/typer/pull/978) by [@​tiangolo](https://redirect.github.com/tiangolo). - ⬆ Bump ruff from 0.6.3 to 0.6.4. PR [#​975](https://redirect.github.com/fastapi/typer/pull/975) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-material from 9.5.33 to 9.5.34. PR [#​963](https://redirect.github.com/fastapi/typer/pull/963) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump pypa/gh-action-pypi-publish from 1.9.0 to 1.10.1. PR [#​973](https://redirect.github.com/fastapi/typer/pull/973) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​966](https://redirect.github.com/fastapi/typer/pull/966) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - 💚 Set `include-hidden-files` to `True` when using the `upload-artifact` GH action. PR [#​967](https://redirect.github.com/fastapi/typer/pull/967) by [@​svlandeg](https://redirect.github.com/svlandeg). - ⬆ Bump ruff from 0.6.1 to 0.6.3. PR [#​961](https://redirect.github.com/fastapi/typer/pull/961) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​689](https://redirect.github.com/fastapi/typer/pull/689) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump ruff from 0.2.0 to 0.6.1. PR [#​938](https://redirect.github.com/fastapi/typer/pull/938) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - 👷 Update `latest-changes` GitHub Action. PR [#​955](https://redirect.github.com/fastapi/typer/pull/955) by [@​tiangolo](https://redirect.github.com/tiangolo). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43LjEiLCJ1cGRhdGVkSW5WZXIiOiIzOS43LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Now that 3.8 is EoL, we can finally update to use 3.9's generic syntax! --------- Co-authored-by: Dylan Anthony <[email protected]>
…enapi-generators#1155) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pypa/gh-action-pypi-publish](https://redirect.github.com/pypa/gh-action-pypi-publish) | action | minor | `v1.10.3` -> `v1.12.2` | --- ### Release Notes <details> <summary>pypa/gh-action-pypi-publish (pypa/gh-action-pypi-publish)</summary> ### [`v1.12.2`](https://redirect.github.com/pypa/gh-action-pypi-publish/releases/tag/v1.12.2) [Compare Source](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.12.1...v1.12.2) #### 🐛 What's Fixed The fix for signing legacy zip sdists turned out to be incomplete, so [@​woodruffw](https://redirect.github.com/woodruffw)[💰](https://redirect.github.com/sponsors/woodruffw) promptly produced another follow-up that updated `pypi-attestations` from v0.0.13 to v0.0.15 in [#​297](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/297). This is the only change since the previous release. **🪞 Full Diff**: pypa/gh-action-pypi-publish@v1.12.1...v1.12.2 **🧔♂️ Release Manager:** [@​webknjaz](https://redirect.github.com/sponsors/webknjaz) [🇺🇦](https://stand-with-ukraine.pp.ua) ### [`v1.12.1`](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.12.0...v1.12.1) [Compare Source](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.12.0...v1.12.1) ### [`v1.12.0`](https://redirect.github.com/pypa/gh-action-pypi-publish/releases/tag/v1.12.0) [Compare Source](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.11.0...v1.12.0) ##### ⚡️ Why Should You Update? This is a minor version bump, but it does not add any new user-facing interfaces. Still, I felt like it should not be a patch-release: this update brings *significant changes* to the action invocation and internal release process. Previously, each invocation of [`pypi-publish`][pypi-publish] required building a container image in the invoking CI job. This was inefficient and added about 30 seconds to the publishing jobs at their startup just to build the container. I wanted to improve this for over three years ([#​58](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/58)) and a little over half a year ago [@​br3ndonland](https://redirect.github.com/br3ndonland)[💰](https://redirect.github.com/sponsors/br3ndonland) stepped up and offered a very comprehensive solution to the limitation I was hoping to overcome: [#​230](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/230). Going forward, I'm going to pre-build per-version containers prior to cutting each release. And the action invocations will just pull the image from GitHub Container registry. **🪞 Full Diff**: pypa/gh-action-pypi-publish@v1.11.0...v1.12.0 **🧔♂️ Release Manager:** [@​webknjaz 🇺🇦](https://redirect.github.com/sponsors/webknjaz) [`pypi-publish`]: https://redirect.github.com/marketplace/actions/pypi-publish ### [`v1.11.0`](https://redirect.github.com/pypa/gh-action-pypi-publish/releases/tag/v1.11.0) [Compare Source](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.10.3...v1.11.0) #### 🔏 Helping you become a trusted supply chain link 🔗 Two months ago, in [v1.10.0](https://redirect.github.com/pypa/gh-action-pypi-publish/releases/tag/v1.10.0), [@​woodruffw](https://redirect.github.com/woodruffw)[💰](https://redirect.github.com/sponsors/woodruffw) integrated support for generating and uploading [PEP 740] digital attestations that can be used as provenance objects when analyzing dependency chains for the integrity. To make sure it works well, it was implemented as an opt-in, so a relatively small subset of projects was able to try it out, and a few issues have been determined and fixed during this time. That changes today! This version changes the feature toggle to [“on by default”](https://redirect.github.com/marketplace/actions/pypi-publish#generating-and-uploading-attestations). This means that from now on, every project making use of Trusted Publishing will start producing and publishing digital attestations without having to do any modifications to how they use this action. [@​woodruffw](https://redirect.github.com/woodruffw)[💰](https://redirect.github.com/sponsors/woodruffw) flipped the respective toggle in [#​277](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/277) with the possibility to opt-out. #### 🛠️ Internal Dependencies [@​woodruffw](https://redirect.github.com/woodruffw)[💰](https://redirect.github.com/sponsors/woodruffw) bumped `sigstore` to v3.5.1 and `pypi-attestations` to v0.0.13 in lock files via [#​276](https://redirect.github.com/pypa/gh-action-pypi-publish/issues/276). **🪞 Full Diff**: pypa/gh-action-pypi-publish@v1.10.3...v1.11.0 **🧔♂️ Release Manager:** [@​webknjaz 🇺🇦](https://redirect.github.com/sponsors/webknjaz) **🙏 Special Thanks** to William for working on improving the supply chain provenance in the ecosystem! The overall effort is tracked @&#[https://github.com/pypi/warehouse/issues/15871](https://redirect.github.com/pypi/warehouse/issues/15871)/15871. [PEP 740]: https://peps.python.org/pep-0740/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMzMuMSIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [ruff](https://docs.astral.sh/ruff) ([source](https://redirect.github.com/astral-sh/ruff), [changelog](https://redirect.github.com/astral-sh/ruff/blob/main/CHANGELOG.md)) | `>=0.2,<0.8` -> `>=0.2,<0.9` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>astral-sh/ruff (ruff)</summary> ### [`v0.8.0`](https://redirect.github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#080) [Compare Source](https://redirect.github.com/astral-sh/ruff/compare/0.7.4...0.8.0) Check out the [blog post](https://astral.sh/blog/ruff-v0.8.0) for a migration guide and overview of the changes! ##### Breaking changes See also, the "Remapped rules" section which may result in disabled rules. - **Default to Python 3.9** Ruff now defaults to Python 3.9 instead of 3.8 if no explicit Python version is configured using [`ruff.target-version`](https://docs.astral.sh/ruff/settings/#target-version) or [`project.requires-python`](https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#python-requires) ([#​13896](https://redirect.github.com/astral-sh/ruff/pull/13896)) - **Changed location of `pydoclint` diagnostics** [`pydoclint`](https://docs.astral.sh/ruff/rules/#pydoclint-doc) diagnostics now point to the first-line of the problematic docstring. Previously, this was not the case. If you've opted into these preview rules but have them suppressed using [`noqa`](https://docs.astral.sh/ruff/linter/#error-suppression) comments in some places, this change may mean that you need to move the `noqa` suppression comments. Most users should be unaffected by this change. - **Use XDG (i.e. `~/.local/bin`) instead of the Cargo home directory in the standalone installer** Previously, Ruff's installer used `$CARGO_HOME` or `~/.cargo/bin` for its target install directory. Now, Ruff will be installed into `$XDG_BIN_HOME`, `$XDG_DATA_HOME/../bin`, or `~/.local/bin` (in that order). This change is only relevant to users of the standalone Ruff installer (using the shell or PowerShell script). If you installed Ruff using uv or pip, you should be unaffected. - **Changes to the line width calculation** Ruff now uses a new version of the [unicode-width](https://redirect.github.com/unicode-rs/unicode-width) Rust crate to calculate the line width. In very rare cases, this may lead to lines containing Unicode characters being reformatted, or being considered too long when they were not before ([`E501`](https://docs.astral.sh/ruff/rules/line-too-long/)). ##### Removed Rules The following deprecated rules have been removed: - [`missing-type-self`](https://docs.astral.sh/ruff/rules/missing-type-self/) (`ANN101`) - [`missing-type-cls`](https://docs.astral.sh/ruff/rules/missing-type-cls/) (`ANN102`) - [`syntax-error`](https://docs.astral.sh/ruff/rules/syntax-error/) (`E999`) - [`pytest-missing-fixture-name-underscore`](https://docs.astral.sh/ruff/rules/pytest-missing-fixture-name-underscore/) (`PT004`) - [`pytest-incorrect-fixture-name-underscore`](https://docs.astral.sh/ruff/rules/pytest-incorrect-fixture-name-underscore/) (`PT005`) - [`unpacked-list-comprehension`](https://docs.astral.sh/ruff/rules/unpacked-list-comprehension/) (`UP027`) ##### Remapped rules The following rules have been remapped to new rule codes: - [`flake8-type-checking`](https://docs.astral.sh/ruff/rules/#flake8-type-checking-tc): `TCH` to `TC` ##### Stabilization The following rules have been stabilized and are no longer in preview: - [`builtin-import-shadowing`](https://docs.astral.sh/ruff/rules/builtin-import-shadowing/) (`A004`) - [`mutable-contextvar-default`](https://docs.astral.sh/ruff/rules/mutable-contextvar-default/) (`B039`) - [`fast-api-redundant-response-model`](https://docs.astral.sh/ruff/rules/fast-api-redundant-response-model/) (`FAST001`) - [`fast-api-non-annotated-dependency`](https://docs.astral.sh/ruff/rules/fast-api-non-annotated-dependency/) (`FAST002`) - [`dict-index-missing-items`](https://docs.astral.sh/ruff/rules/dict-index-missing-items/) (`PLC0206`) - [`pep484-style-positional-only-argument`](https://docs.astral.sh/ruff/rules/pep484-style-positional-only-argument/) (`PYI063`) - [`redundant-final-literal`](https://docs.astral.sh/ruff/rules/redundant-final-literal/) (`PYI064`) - [`bad-version-info-order`](https://docs.astral.sh/ruff/rules/bad-version-info-order/) (`PYI066`) - [`parenthesize-chained-operators`](https://docs.astral.sh/ruff/rules/parenthesize-chained-operators/) (`RUF021`) - [`unsorted-dunder-all`](https://docs.astral.sh/ruff/rules/unsorted-dunder-all/) (`RUF022`) - [`unsorted-dunder-slots`](https://docs.astral.sh/ruff/rules/unsorted-dunder-slots/) (`RUF023`) - [`assert-with-print-message`](https://docs.astral.sh/ruff/rules/assert-with-print-message/) (`RUF030`) - [`unnecessary-default-type-args`](https://docs.astral.sh/ruff/rules/unnecessary-default-type-args/) (`UP043`) The following behaviors have been stabilized: - [`ambiguous-variable-name`](https://docs.astral.sh/ruff/rules/ambiguous-variable-name/) (`E741`): Violations in stub files are now ignored. Stub authors typically don't control variable names. - [`printf-string-formatting`](https://docs.astral.sh/ruff/rules/printf-string-formatting/) (`UP031`): Report all `printf`-like usages even if no autofix is available The following fixes have been stabilized: - [`zip-instead-of-pairwise`](https://docs.astral.sh/ruff/rules/zip-instead-of-pairwise/) (`RUF007`) ##### Preview features - \[`flake8-datetimez`] Exempt `min.time()` and `max.time()` (`DTZ901`) ([#​14394](https://redirect.github.com/astral-sh/ruff/pull/14394)) - \[`flake8-pie`] Mark fix as unsafe if the following statement is a string literal (`PIE790`) ([#​14393](https://redirect.github.com/astral-sh/ruff/pull/14393)) - \[`flake8-pyi`] New rule `redundant-none-literal` (`PYI061`) ([#​14316](https://redirect.github.com/astral-sh/ruff/pull/14316)) - \[`flake8-pyi`] Add autofix for `redundant-numeric-union` (`PYI041`) ([#​14273](https://redirect.github.com/astral-sh/ruff/pull/14273)) - \[`ruff`] New rule `map-int-version-parsing` (`RUF048`) ([#​14373](https://redirect.github.com/astral-sh/ruff/pull/14373)) - \[`ruff`] New rule `redundant-bool-literal` (`RUF038`) ([#​14319](https://redirect.github.com/astral-sh/ruff/pull/14319)) - \[`ruff`] New rule `unraw-re-pattern` (`RUF039`) ([#​14446](https://redirect.github.com/astral-sh/ruff/pull/14446)) - \[`pycodestyle`] Exempt `pytest.importorskip()` calls (`E402`) ([#​14474](https://redirect.github.com/astral-sh/ruff/pull/14474)) - \[`pylint`] Autofix suggests using sets when possible (`PLR1714`) ([#​14372](https://redirect.github.com/astral-sh/ruff/pull/14372)) ##### Rule changes - [`invalid-pyproject-toml`](https://docs.astral.sh/ruff/rules/invalid-pyproject-toml/) (`RUF200`): Updated to reflect the provisionally accepted [PEP 639](https://peps.python.org/pep-0639/). - \[`flake8-pyi`] Avoid panic in unfixable case (`PYI041`) ([#​14402](https://redirect.github.com/astral-sh/ruff/pull/14402)) - \[`flake8-type-checking`] Correctly handle quotes in subscript expression when generating an autofix ([#​14371](https://redirect.github.com/astral-sh/ruff/pull/14371)) - \[`pylint`] Suggest correct autofix for `__contains__` (`PLC2801`) ([#​14424](https://redirect.github.com/astral-sh/ruff/pull/14424)) ##### Configuration - Ruff now emits a warning instead of an error when a configuration [`ignore`](https://docs.astral.sh/ruff/settings/#lint_ignore)s a rule that has been removed ([#​14435](https://redirect.github.com/astral-sh/ruff/pull/14435)) - Ruff now validates that `lint.flake8-import-conventions.aliases` only uses valid module names and aliases ([#​14477](https://redirect.github.com/astral-sh/ruff/pull/14477)) ### [`v0.7.4`](https://redirect.github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#074) [Compare Source](https://redirect.github.com/astral-sh/ruff/compare/0.7.3...0.7.4) ##### Preview features - \[`flake8-datetimez`] Detect usages of `datetime.max`/`datetime.min` (`DTZ901`) ([#​14288](https://redirect.github.com/astral-sh/ruff/pull/14288)) - \[`flake8-logging`] Implement `root-logger-calls` (`LOG015`) ([#​14302](https://redirect.github.com/astral-sh/ruff/pull/14302)) - \[`flake8-no-pep420`] Detect empty implicit namespace packages (`INP001`) ([#​14236](https://redirect.github.com/astral-sh/ruff/pull/14236)) - \[`flake8-pyi`] Add "replace with `Self`" fix (`PYI019`) ([#​14238](https://redirect.github.com/astral-sh/ruff/pull/14238)) - \[`perflint`] Implement quick-fix for `manual-list-comprehension` (`PERF401`) ([#​13919](https://redirect.github.com/astral-sh/ruff/pull/13919)) - \[`pylint`] Implement `shallow-copy-environ` (`W1507`) ([#​14241](https://redirect.github.com/astral-sh/ruff/pull/14241)) - \[`ruff`] Implement `none-not-at-end-of-union` (`RUF036`) ([#​14314](https://redirect.github.com/astral-sh/ruff/pull/14314)) - \[`ruff`] Implementation `unsafe-markup-call` from `flake8-markupsafe` plugin (`RUF035`) ([#​14224](https://redirect.github.com/astral-sh/ruff/pull/14224)) - \[`ruff`] Report problems for `attrs` dataclasses (`RUF008`, `RUF009`) ([#​14327](https://redirect.github.com/astral-sh/ruff/pull/14327)) ##### Rule changes - \[`flake8-boolean-trap`] Exclude dunder methods that define operators (`FBT001`) ([#​14203](https://redirect.github.com/astral-sh/ruff/pull/14203)) - \[`flake8-pyi`] Add "replace with `Self`" fix (`PYI034`) ([#​14217](https://redirect.github.com/astral-sh/ruff/pull/14217)) - \[`flake8-pyi`] Always autofix `duplicate-union-members` (`PYI016`) ([#​14270](https://redirect.github.com/astral-sh/ruff/pull/14270)) - \[`flake8-pyi`] Improve autofix for nested and mixed type unions for `unnecessary-type-union` (`PYI055`) ([#​14272](https://redirect.github.com/astral-sh/ruff/pull/14272)) - \[`flake8-pyi`] Mark fix as unsafe when type annotation contains comments for `duplicate-literal-member` (`PYI062`) ([#​14268](https://redirect.github.com/astral-sh/ruff/pull/14268)) ##### Server - Use the current working directory to resolve settings from `ruff.configuration` ([#​14352](https://redirect.github.com/astral-sh/ruff/pull/14352)) ##### Bug fixes - Avoid conflicts between `PLC014` (`useless-import-alias`) and `I002` (`missing-required-import`) by considering `lint.isort.required-imports` for `PLC014` ([#​14287](https://redirect.github.com/astral-sh/ruff/pull/14287)) - \[`flake8-type-checking`] Skip quoting annotation if it becomes invalid syntax (`TCH001`) - \[`flake8-pyi`] Avoid using `typing.Self` in stub files pre-Python 3.11 (`PYI034`) ([#​14230](https://redirect.github.com/astral-sh/ruff/pull/14230)) - \[`flake8-pytest-style`] Flag `pytest.raises` call with keyword argument `expected_exception` (`PT011`) ([#​14298](https://redirect.github.com/astral-sh/ruff/pull/14298)) - \[`flake8-simplify`] Infer "unknown" truthiness for literal iterables whose items are all unpacks (`SIM222`) ([#​14263](https://redirect.github.com/astral-sh/ruff/pull/14263)) - \[`flake8-type-checking`] Fix false positives for `typing.Annotated` (`TCH001`) ([#​14311](https://redirect.github.com/astral-sh/ruff/pull/14311)) - \[`pylint`] Allow `await` at the top-level scope of a notebook (`PLE1142`) ([#​14225](https://redirect.github.com/astral-sh/ruff/pull/14225)) - \[`pylint`] Fix miscellaneous issues in `await-outside-async` detection (`PLE1142`) ([#​14218](https://redirect.github.com/astral-sh/ruff/pull/14218)) - \[`pyupgrade`] Avoid applying PEP 646 rewrites in invalid contexts (`UP044`) ([#​14234](https://redirect.github.com/astral-sh/ruff/pull/14234)) - \[`pyupgrade`] Detect permutations in redundant open modes (`UP015`) ([#​14255](https://redirect.github.com/astral-sh/ruff/pull/14255)) - \[`refurb`] Avoid triggering `hardcoded-string-charset` for reordered sets (`FURB156`) ([#​14233](https://redirect.github.com/astral-sh/ruff/pull/14233)) - \[`refurb`] Further special cases added to `verbose-decimal-constructor` (`FURB157`) ([#​14216](https://redirect.github.com/astral-sh/ruff/pull/14216)) - \[`refurb`] Use `UserString` instead of non-existent `UserStr` (`FURB189`) ([#​14209](https://redirect.github.com/astral-sh/ruff/pull/14209)) - \[`ruff`] Avoid treating lowercase letters as `# noqa` codes (`RUF100`) ([#​14229](https://redirect.github.com/astral-sh/ruff/pull/14229)) - \[`ruff`] Do not report when `Optional` has no type arguments (`RUF013`) ([#​14181](https://redirect.github.com/astral-sh/ruff/pull/14181)) ##### Documentation - Add "Notebook behavior" section for `F704`, `PLE1142` ([#​14266](https://redirect.github.com/astral-sh/ruff/pull/14266)) - Document comment policy around fix safety ([#​14300](https://redirect.github.com/astral-sh/ruff/pull/14300)) ### [`v0.7.3`](https://redirect.github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#073) [Compare Source](https://redirect.github.com/astral-sh/ruff/compare/0.7.2...0.7.3) ##### Preview features - Formatter: Disallow single-line implicit concatenated strings ([#​13928](https://redirect.github.com/astral-sh/ruff/pull/13928)) - \[`flake8-pyi`] Include all Python file types for `PYI006` and `PYI066` ([#​14059](https://redirect.github.com/astral-sh/ruff/pull/14059)) - \[`flake8-simplify`] Implement `split-of-static-string` (`SIM905`) ([#​14008](https://redirect.github.com/astral-sh/ruff/pull/14008)) - \[`refurb`] Implement `subclass-builtin` (`FURB189`) ([#​14105](https://redirect.github.com/astral-sh/ruff/pull/14105)) - \[`ruff`] Improve diagnostic messages and docs (`RUF031`, `RUF032`, `RUF034`) ([#​14068](https://redirect.github.com/astral-sh/ruff/pull/14068)) ##### Rule changes - Detect items that hash to same value in duplicate sets (`B033`, `PLC0208`) ([#​14064](https://redirect.github.com/astral-sh/ruff/pull/14064)) - \[`eradicate`] Better detection of IntelliJ language injection comments (`ERA001`) ([#​14094](https://redirect.github.com/astral-sh/ruff/pull/14094)) - \[`flake8-pyi`] Add autofix for `docstring-in-stub` (`PYI021`) ([#​14150](https://redirect.github.com/astral-sh/ruff/pull/14150)) - \[`flake8-pyi`] Update `duplicate-literal-member` (`PYI062`) to alawys provide an autofix ([#​14188](https://redirect.github.com/astral-sh/ruff/pull/14188)) - \[`pyflakes`] Detect items that hash to same value in duplicate dictionaries (`F601`) ([#​14065](https://redirect.github.com/astral-sh/ruff/pull/14065)) - \[`ruff`] Fix false positive for decorators (`RUF028`) ([#​14061](https://redirect.github.com/astral-sh/ruff/pull/14061)) ##### Bug fixes - Avoid parsing joint rule codes as distinct codes in `# noqa` ([#​12809](https://redirect.github.com/astral-sh/ruff/pull/12809)) - \[`eradicate`] ignore `# language=` in commented-out-code rule (ERA001) ([#​14069](https://redirect.github.com/astral-sh/ruff/pull/14069)) - \[`flake8-bugbear`] - do not run `mutable-argument-default` on stubs (`B006`) ([#​14058](https://redirect.github.com/astral-sh/ruff/pull/14058)) - \[`flake8-builtins`] Skip lambda expressions in `builtin-argument-shadowing (A002)` ([#​14144](https://redirect.github.com/astral-sh/ruff/pull/14144)) - \[`flake8-comprehension`] Also remove trailing comma while fixing `C409` and `C419` ([#​14097](https://redirect.github.com/astral-sh/ruff/pull/14097)) - \[`flake8-simplify`] Allow `open` without context manager in `return` statement (`SIM115`) ([#​14066](https://redirect.github.com/astral-sh/ruff/pull/14066)) - \[`pylint`] Respect hash-equivalent literals in `iteration-over-set` (`PLC0208`) ([#​14063](https://redirect.github.com/astral-sh/ruff/pull/14063)) - \[`pylint`] Update known dunder methods for Python 3.13 (`PLW3201`) ([#​14146](https://redirect.github.com/astral-sh/ruff/pull/14146)) - \[`pyupgrade`] - ignore kwarg unpacking for `UP044` ([#​14053](https://redirect.github.com/astral-sh/ruff/pull/14053)) - \[`refurb`] Parse more exotic decimal strings in `verbose-decimal-constructor` (`FURB157`) ([#​14098](https://redirect.github.com/astral-sh/ruff/pull/14098)) ##### Documentation - Add links to missing related options within rule documentations ([#​13971](https://redirect.github.com/astral-sh/ruff/pull/13971)) - Add rule short code to mkdocs tags to allow searching via rule codes ([#​14040](https://redirect.github.com/astral-sh/ruff/pull/14040)) ### [`v0.7.2`](https://redirect.github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#072) [Compare Source](https://redirect.github.com/astral-sh/ruff/compare/0.7.1...0.7.2) ##### Preview features - Fix formatting of single with-item with trailing comment ([#​14005](https://redirect.github.com/astral-sh/ruff/pull/14005)) - \[`pyupgrade`] Add PEP 646 `Unpack` conversion to `*` with fix (`UP044`) ([#​13988](https://redirect.github.com/astral-sh/ruff/pull/13988)) ##### Rule changes - Regenerate `known_stdlibs.rs` with stdlibs 2024.10.25 ([#​13963](https://redirect.github.com/astral-sh/ruff/pull/13963)) - \[`flake8-no-pep420`] Skip namespace package enforcement for PEP 723 scripts (`INP001`) ([#​13974](https://redirect.github.com/astral-sh/ruff/pull/13974)) ##### Server - Fix server panic when undoing an edit ([#​14010](https://redirect.github.com/astral-sh/ruff/pull/14010)) ##### Bug fixes - Fix issues in discovering ruff in pip build environments ([#​13881](https://redirect.github.com/astral-sh/ruff/pull/13881)) - \[`flake8-type-checking`] Fix false positive for `singledispatchmethod` (`TCH003`) ([#​13941](https://redirect.github.com/astral-sh/ruff/pull/13941)) - \[`flake8-type-checking`] Treat return type of `singledispatch` as runtime-required (`TCH003`) ([#​13957](https://redirect.github.com/astral-sh/ruff/pull/13957)) ##### Documentation - \[`flake8-simplify`] Include caveats of enabling `if-else-block-instead-of-if-exp` (`SIM108`) ([#​14019](https://redirect.github.com/astral-sh/ruff/pull/14019)) ### [`v0.7.1`](https://redirect.github.com/astral-sh/ruff/blob/HEAD/CHANGELOG.md#071) [Compare Source](https://redirect.github.com/astral-sh/ruff/compare/0.7.0...0.7.1) ##### Preview features - Fix `E221` and `E222` to flag missing or extra whitespace around `==` operator ([#​13890](https://redirect.github.com/astral-sh/ruff/pull/13890)) - Formatter: Alternate quotes for strings inside f-strings in preview ([#​13860](https://redirect.github.com/astral-sh/ruff/pull/13860)) - Formatter: Join implicit concatenated strings when they fit on a line ([#​13663](https://redirect.github.com/astral-sh/ruff/pull/13663)) - \[`pylint`] Restrict `iteration-over-set` to only work on sets of literals (`PLC0208`) ([#​13731](https://redirect.github.com/astral-sh/ruff/pull/13731)) ##### Rule changes - \[`flake8-type-checking`] Support auto-quoting when annotations contain quotes ([#​11811](https://redirect.github.com/astral-sh/ruff/pull/11811)) ##### Server - Avoid indexing the workspace for single-file mode ([#​13770](https://redirect.github.com/astral-sh/ruff/pull/13770)) ##### Bug fixes - Make `ARG002` compatible with `EM101` when raising `NotImplementedError` ([#​13714](https://redirect.github.com/astral-sh/ruff/pull/13714)) ##### Other changes - Introduce more Docker tags for Ruff (similar to uv) ([#​13274](https://redirect.github.com/astral-sh/ruff/pull/13274)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dylan Anthony <[email protected]>
> [!IMPORTANT] > Merging this pull request will create this release ## Breaking Changes ### Drop support for Python 3.8 Python 3.8 is no longer supported. "New" 3.9 syntax, like generics on builtin collections, is used both in the generator and the generated code. ### `type` is now a reserved field name Because `type` is used in type annotations now, it is no longer a valid field name. Fields which were previously named `type` will be renamed to `type_`. ## Features - Support Ruff 0.8 (openapi-generators#1169) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
…enapi-generators#1177) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pypa/gh-action-pypi-publish](https://redirect.github.com/pypa/gh-action-pypi-publish) | action | patch | `v1.12.2` -> `v1.12.3` | --- ### Release Notes <details> <summary>pypa/gh-action-pypi-publish (pypa/gh-action-pypi-publish)</summary> ### [`v1.12.3`](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.12.2...v1.12.3) [Compare Source](https://redirect.github.com/pypa/gh-action-pypi-publish/compare/v1.12.2...v1.12.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS40Mi40IiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…-generators#1178) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/upload-artifact](https://redirect.github.com/actions/upload-artifact) | action | minor | `v4.4.3` -> `v4.5.0` | --- ### Release Notes <details> <summary>actions/upload-artifact (actions/upload-artifact)</summary> ### [`v4.5.0`](https://redirect.github.com/actions/upload-artifact/compare/v4.4.3...v4.5.0) [Compare Source](https://redirect.github.com/actions/upload-artifact/compare/v4.4.3...v4.5.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43Mi4yIiwidXBkYXRlZEluVmVyIjoiMzkuNzIuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This is the alternative approach I mentioned in openapi-generators#1171 (comment). Instead of trying to rebuild the models in their respective modules (which requires weird patterns, such as unused imports or importing after the model is defined), we set `defer_build` to `True` for every model where we know a forward reference will fail to resolve (so that we don't try to build a model if we know it will fail). I added comments each time to justify the use of `defer_build`, but unfortunately this isn't always straightforward (e.g. sometimes you makes use of a model as annotation which itself has `defer_build` set; in this case we also want to defer build. Another case is when making use of the `Callback` type alias; it isn't directly visible but it uses an unresolvable forward reference). Ultimately, in the module's `__init__.py`, we call `model_rebuild` on all the necessary models. I know this isn't ideal as well, as you need to manually check for every exported model here if the build was successful. This library is a clear example that inter-dependent types across different modules is challenging, and Pydantic does not make it easy. We are trying to think about ways to simplify the process. Note that on top of fixing things for Pydantic 2.10, this also ensures every model is successfully built when the `openapi_schema_pydantic` module is imported. Currently on `main` (with Pydantic 2.9.2), some models such as `Components` are not built. While this can still work in some cases, it is advised not to do so (when `Components` is going to be instantiated, Pydantic will implicitly try to rebuild it if it wasn't already. However, we use the namespace where the instantiation call happened to rebuilt it, so depending on _where_ you first instantiate the model, this can lead to a failed model rebuild and thus a runtime exception). --- A note on `model_rebuild`: you can either provide an explicit namespace: ```python PathItem.model_rebuild(_types_namespace={Operation: "Operation", "Header": Header}) ``` Or let `model_rebuild` use the namespace where it was called (in our case, all the imports are available, so it works). --------- Co-authored-by: Dylan Anthony <[email protected]> Co-authored-by: Dylan Anthony <[email protected]>
This way, when we upgrade the upper limit of a dependency (and the version we test for most of the time), we don't accidentally break our listed minimum version. --------- Co-authored-by: Dylan Anthony <[email protected]>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [typer](https://redirect.github.com/fastapi/typer) ([changelog](https://typer.tiangolo.com/release-notes/)) | `>0.6,<0.14` -> `>0.6,<0.16` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>fastapi/typer (typer)</summary> ### [`v0.15.0`](https://redirect.github.com/fastapi/typer/releases/tag/0.15.0) [Compare Source](https://redirect.github.com/fastapi/typer/compare/0.14.0...0.15.0) ##### Features - ✨ Add support for extending typer apps without passing a name, add commands to the top level. PR [#​1037](https://redirect.github.com/fastapi/typer/pull/1037) by [@​patrick91](https://redirect.github.com/patrick91). - New docs: [One File Per Command](https://typer.tiangolo.com/tutorial/one-file-per-command/). ##### Internal - ⬆ Bump mkdocs-material from 9.5.46 to 9.5.47. PR [#​1070](https://redirect.github.com/fastapi/typer/pull/1070) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump ruff from 0.8.0 to 0.8.1. PR [#​1066](https://redirect.github.com/fastapi/typer/pull/1066) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). ### [`v0.14.0`](https://redirect.github.com/fastapi/typer/releases/tag/0.14.0) [Compare Source](https://redirect.github.com/fastapi/typer/compare/0.13.1...0.14.0) ##### Breaking Changes - 🔥 Remove auto naming of groups added via `add_typer` based on the group's callback function name. PR [#​1052](https://redirect.github.com/fastapi/typer/pull/1052) by [@​patrick91](https://redirect.github.com/patrick91). Before, it was supported to infer the name of a command group from the callback function name in the sub-app, so, in this code: ```python import typer app = typer.Typer() users_app = typer.Typer() app.add_typer(users_app) @​users_app.callback() def users(): # <-- This was the inferred command group name """ Manage users in the app. """ @​users_app.command() def create(name: str): print(f"Creating user: {name}") ``` ...the command group would be named `users`, based on the name of the function `def users()`. Now you need to set it explicitly: ```python import typer app = typer.Typer() users_app = typer.Typer() app.add_typer(users_app, name="users") # <-- Explicitly set the command group name @​users_app.callback() def users(): """ Manage users in the app. """ @​users_app.command() def create(name: str): print(f"Creating user: {name}") ``` Updated docs [SubCommand Name and Help](https://typer.tiangolo.com/tutorial/subcommands/name-and-help/). **Note**: this change will enable important features in the next release. 🤩 ##### Internal - ⬆ Bump pypa/gh-action-pypi-publish from 1.10.3 to 1.12.2. PR [#​1043](https://redirect.github.com/fastapi/typer/pull/1043) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-material from 9.5.44 to 9.5.46. PR [#​1062](https://redirect.github.com/fastapi/typer/pull/1062) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump ruff from 0.7.4 to 0.8.0. PR [#​1059](https://redirect.github.com/fastapi/typer/pull/1059) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump astral-sh/setup-uv from 3 to 4. PR [#​1061](https://redirect.github.com/fastapi/typer/pull/1061) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​1053](https://redirect.github.com/fastapi/typer/pull/1053) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). ### [`v0.13.1`](https://redirect.github.com/fastapi/typer/releases/tag/0.13.1) [Compare Source](https://redirect.github.com/fastapi/typer/compare/0.13.0...0.13.1) ##### Features - ✨ Remove Rich tags when showing completion text. PR [#​877](https://redirect.github.com/fastapi/typer/pull/877) by [@​svlandeg](https://redirect.github.com/svlandeg). - ✨ Render Rich markup as HTML in Markdown docs. PR [#​847](https://redirect.github.com/fastapi/typer/pull/847) by [@​svlandeg](https://redirect.github.com/svlandeg). - ✨ Support cp850 encoding for auto-completion in PowerShell. PR [#​808](https://redirect.github.com/fastapi/typer/pull/808) by [@​svlandeg](https://redirect.github.com/svlandeg). - ✨ Allow gettext translation of help message. PR [#​886](https://redirect.github.com/fastapi/typer/pull/886) by [@​svlandeg](https://redirect.github.com/svlandeg). ##### Refactors - 🐛 Fix printing HTML from Rich output. PR [#​1055](https://redirect.github.com/fastapi/typer/pull/1055) by [@​tiangolo](https://redirect.github.com/tiangolo). ##### Docs - 📝 Update markdown includes to use the new simpler format. PR [#​1054](https://redirect.github.com/fastapi/typer/pull/1054) by [@​tiangolo](https://redirect.github.com/tiangolo). ##### Internal - ⬆ Bump ruff from 0.7.3 to 0.7.4. PR [#​1051](https://redirect.github.com/fastapi/typer/pull/1051) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​1047](https://redirect.github.com/fastapi/typer/pull/1047) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump ruff from 0.7.2 to 0.7.3. PR [#​1046](https://redirect.github.com/fastapi/typer/pull/1046) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump tiangolo/latest-changes from 0.3.1 to 0.3.2. PR [#​1044](https://redirect.github.com/fastapi/typer/pull/1044) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Update pytest-cov requirement from <6.0.0,>=2.10.0 to >=2.10.0,<7.0.0. PR [#​1033](https://redirect.github.com/fastapi/typer/pull/1033) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). ### [`v0.13.0`](https://redirect.github.com/fastapi/typer/releases/tag/0.13.0) [Compare Source](https://redirect.github.com/fastapi/typer/compare/0.12.5...0.13.0) ##### Features - ✨ Handle `KeyboardInterrupt` separately from other exceptions. PR [#​1039](https://redirect.github.com/fastapi/typer/pull/1039) by [@​patrick91](https://redirect.github.com/patrick91). - ✨ Update `launch` to not print anything when opening urls. PR [#​1035](https://redirect.github.com/fastapi/typer/pull/1035) by [@​patrick91](https://redirect.github.com/patrick91). - ✨ Show help items in order of definition. PR [#​944](https://redirect.github.com/fastapi/typer/pull/944) by [@​svlandeg](https://redirect.github.com/svlandeg). ##### Fixes - 🐛 Fix equality check for custom classes. PR [#​979](https://redirect.github.com/fastapi/typer/pull/979) by [@​AryazE](https://redirect.github.com/AryazE). - 🐛 Allow colon in zsh autocomplete values and descriptions. PR [#​988](https://redirect.github.com/fastapi/typer/pull/988) by [@​snapbug](https://redirect.github.com/snapbug). ##### Refactors - 🗑️ Deprecate support for `is_flag` and `flag_value` parameters. PR [#​987](https://redirect.github.com/fastapi/typer/pull/987) by [@​svlandeg](https://redirect.github.com/svlandeg). - 🔥 Remove unused functionality from `_typing.py` file. PR [#​805](https://redirect.github.com/fastapi/typer/pull/805) by [@​ivantodorovich](https://redirect.github.com/ivantodorovich). - ✏️ Fix typo in function name `_make_rich_text`. PR [#​959](https://redirect.github.com/fastapi/typer/pull/959) by [@​svlandeg](https://redirect.github.com/svlandeg). ##### Internal - ✅ Only run completion installation tests when the env var `_TYPER_RUN_INSTALL_COMPLETION_TESTS` is set. PR [#​995](https://redirect.github.com/fastapi/typer/pull/995) by [@​svlandeg](https://redirect.github.com/svlandeg). - 📝 Update the docstring of the `_make_rich_text` method. PR [#​972](https://redirect.github.com/fastapi/typer/pull/972) by [@​svlandeg](https://redirect.github.com/svlandeg). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​1040](https://redirect.github.com/fastapi/typer/pull/1040) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump mkdocs-material from 9.5.42 to 9.5.44. PR [#​1042](https://redirect.github.com/fastapi/typer/pull/1042) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump ruff from 0.7.1 to 0.7.2. PR [#​1038](https://redirect.github.com/fastapi/typer/pull/1038) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-macros-plugin from 1.3.6 to 1.3.7. PR [#​1031](https://redirect.github.com/fastapi/typer/pull/1031) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​1032](https://redirect.github.com/fastapi/typer/pull/1032) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump ruff from 0.7.0 to 0.7.1. PR [#​1029](https://redirect.github.com/fastapi/typer/pull/1029) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump pillow from 10.4.0 to 11.0.0. PR [#​1023](https://redirect.github.com/fastapi/typer/pull/1023) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-material from 9.5.35 to 9.5.42. PR [#​1027](https://redirect.github.com/fastapi/typer/pull/1027) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump ruff from 0.6.5 to 0.7.0. PR [#​1026](https://redirect.github.com/fastapi/typer/pull/1026) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-macros-plugin from 1.2.0 to 1.3.6. PR [#​1025](https://redirect.github.com/fastapi/typer/pull/1025) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Update pre-commit requirement from <4.0.0,>=2.17.0 to >=2.17.0,<5.0.0. PR [#​1012](https://redirect.github.com/fastapi/typer/pull/1012) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump pypa/gh-action-pypi-publish from 1.10.1 to 1.10.3. PR [#​1009](https://redirect.github.com/fastapi/typer/pull/1009) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​1001](https://redirect.github.com/fastapi/typer/pull/1001) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - 👷 Update Deploy docs CI to use uv. PR [#​1021](https://redirect.github.com/fastapi/typer/pull/1021) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Fix smokeshow, checkout files on CI. PR [#​1020](https://redirect.github.com/fastapi/typer/pull/1020) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Use uv in CI. PR [#​1019](https://redirect.github.com/fastapi/typer/pull/1019) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Update `labeler.yml`. PR [#​1014](https://redirect.github.com/fastapi/typer/pull/1014) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Update worfkow deploy-docs-notify URL. PR [#​1011](https://redirect.github.com/fastapi/typer/pull/1011) by [@​tiangolo](https://redirect.github.com/tiangolo). - 👷 Upgrade Cloudflare GitHub Action. PR [#​1010](https://redirect.github.com/fastapi/typer/pull/1010) by [@​tiangolo](https://redirect.github.com/tiangolo). - ⬆ Bump mkdocs-macros-plugin from 1.0.5 to 1.2.0. PR [#​992](https://redirect.github.com/fastapi/typer/pull/992) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump ruff from 0.6.4 to 0.6.5. PR [#​991](https://redirect.github.com/fastapi/typer/pull/991) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-material from 9.5.34 to 9.5.35. PR [#​996](https://redirect.github.com/fastapi/typer/pull/996) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​993](https://redirect.github.com/fastapi/typer/pull/993) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​982](https://redirect.github.com/fastapi/typer/pull/982) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump tiangolo/issue-manager from 0.5.0 to 0.5.1. PR [#​980](https://redirect.github.com/fastapi/typer/pull/980) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - 👷 Update `issue-manager.yml`. PR [#​978](https://redirect.github.com/fastapi/typer/pull/978) by [@​tiangolo](https://redirect.github.com/tiangolo). - ⬆ Bump ruff from 0.6.3 to 0.6.4. PR [#​975](https://redirect.github.com/fastapi/typer/pull/975) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump mkdocs-material from 9.5.33 to 9.5.34. PR [#​963](https://redirect.github.com/fastapi/typer/pull/963) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ Bump pypa/gh-action-pypi-publish from 1.9.0 to 1.10.1. PR [#​973](https://redirect.github.com/fastapi/typer/pull/973) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​966](https://redirect.github.com/fastapi/typer/pull/966) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - 💚 Set `include-hidden-files` to `True` when using the `upload-artifact` GH action. PR [#​967](https://redirect.github.com/fastapi/typer/pull/967) by [@​svlandeg](https://redirect.github.com/svlandeg). - ⬆ Bump ruff from 0.6.1 to 0.6.3. PR [#​961](https://redirect.github.com/fastapi/typer/pull/961) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - ⬆ \[pre-commit.ci] pre-commit autoupdate. PR [#​689](https://redirect.github.com/fastapi/typer/pull/689) by [@​pre-commit-ci\[bot\]](https://redirect.github.com/apps/pre-commit-ci). - ⬆ Bump ruff from 0.2.0 to 0.6.1. PR [#​938](https://redirect.github.com/fastapi/typer/pull/938) by [@​dependabot\[bot\]](https://redirect.github.com/apps/dependabot). - 👷 Update `latest-changes` GitHub Action. PR [#​955](https://redirect.github.com/fastapi/typer/pull/955) by [@​tiangolo](https://redirect.github.com/tiangolo). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dylan Anthony <[email protected]>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [httpx](https://redirect.github.com/encode/httpx) ([changelog](https://redirect.github.com/encode/httpx/blob/master/CHANGELOG.md)) | `>=0.20.0,<0.28.0` -> `>=0.20.0,<0.29.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [httpx](https://redirect.github.com/encode/httpx) ([changelog](https://redirect.github.com/encode/httpx/blob/master/CHANGELOG.md)) | `>= 0.20.0, < 0.28.0` -> `>=0.20.0, <0.29.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>encode/httpx (httpx)</summary> ### [`v0.28.1`](https://redirect.github.com/encode/httpx/blob/HEAD/CHANGELOG.md#0281-6th-December-2024) [Compare Source](https://redirect.github.com/encode/httpx/compare/0.28.0...0.28.1) - Fix SSL case where `verify=False` together with client side certificates. ### [`v0.28.0`](https://redirect.github.com/encode/httpx/blob/HEAD/CHANGELOG.md#0280-28th-November-2024) [Compare Source](https://redirect.github.com/encode/httpx/compare/0.27.2...0.28.0) The 0.28 release includes a limited set of deprecations. **Deprecations**: We are working towards a simplified SSL configuration API. *For users of the standard `verify=True` or `verify=False` cases, or `verify=<ssl_context>` case this should require no changes. The following cases have been deprecated...* - The `verify` argument as a string argument is now deprecated and will raise warnings. - The `cert` argument is now deprecated and will raise warnings. Our revised [SSL documentation](docs/advanced/ssl.md) covers how to implement the same behaviour with a more constrained API. **The following changes are also included**: - The deprecated `proxies` argument has now been removed. - The deprecated `app` argument has now been removed. - JSON request bodies use a compact representation. ([#​3363](https://redirect.github.com/encode/httpx/issues/3363)) - Review URL percent escape sets, based on WHATWG spec. ([#​3371](https://redirect.github.com/encode/httpx/issues/3371), [#​3373](https://redirect.github.com/encode/httpx/issues/3373)) - Ensure `certifi` and `httpcore` are only imported if required. ([#​3377](https://redirect.github.com/encode/httpx/issues/3377)) - Treat `socks5h` as a valid proxy scheme. ([#​3178](https://redirect.github.com/encode/httpx/issues/3178)) - Cleanup `Request()` method signature in line with `client.request()` and `httpx.request()`. ([#​3378](https://redirect.github.com/encode/httpx/issues/3378)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuNDIuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Dylan Anthony <[email protected]>
This PR contains the following updates: | Update | Change | |---|---| | lockFileMaintenance | All locks refreshed | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMjAuMSIsInVwZGF0ZWRJblZlciI6IjM4LjEyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Closes openapi-generators#1105 Co-authored-by: Dylan Anthony <[email protected]>
Closes openapi-generators#1084 Co-authored-by: Dylan Anthony <[email protected]>
Currently when an endpoint has multiple tags, the first tag is used and everything else is ignored. This PR modifies it so endpoints with multiple tags are added to each of the tags. Yes, this results in repeated code 😅, but works beautifully and functions can now be found anywhere we expect them to be. --------- Co-authored-by: Dylan Anthony <[email protected]> Co-authored-by: Dylan Anthony <[email protected]>
> [!IMPORTANT] > Merging this pull request will create this release ## Breaking Changes ### Delete fewer files with `--overwrite` `--overwrite` will no longer delete the entire output directory before regenerating. Instead, it will only delete specific, known directories within that directory. Right now, that is only the generated `models` and `api` directories. Other generated files, like `README.md`, will be overwritten. Extra files and directories outside of those listed above will be left untouched, so you can any extra modules or files around while still updating `pyproject.toml` automatically. Closes openapi-generators#1105. ## Features - Support httpx 0.28 (openapi-generators#1172) ### Add `generate_all_tags` config option You can now, optionally, generate **duplicate** endpoint functions/modules using _every_ tag for an endpoint, not just the first one, by setting `generate_all_tags: true` in your configuration file. ## Fixes - Support Typer 0.14 and 0.15 (openapi-generators#1173) ### Fix minimum `attrs` version The minimum `attrs` dependency version was incorrectly set to 21.3.0. This has been corrected to 22.2.0, the minimum supported version since `openapi-python-client` 0.19.1. Closes openapi-generators#1084, thanks @astralblue! ### Fix compatibility with Pydantic 2.10+ openapi-generators#1176 by @Viicos Set `defer_build` to models that we know will fail to build, and call `model_rebuild` in the `__init__.py` file. Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
This PR contains the following updates: | Update | Change | |---|---| | lockFileMaintenance | All locks refreshed | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openapi-generators/openapi-python-client). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44NS4wIiwidXBkYXRlZEluVmVyIjoiMzkuODUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.