Modified vcenter_vm_scenario1 test target to run on the eco vsphere env #584
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
=======================================
Coverage 37.04% 37.04%
=======================================
Files 145 145
Lines 11398 11398
Branches 2262 2262
=======================================
Hits 4222 4222
Misses 7176 7176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| file: ../group_vars.yml | ||
| tags: eco-vcenter-ci | ||
|
|
||
| - name: Set facts for tests |
There was a problem hiding this comment.
I think we should add an assertion after this with a helpful error message if any of these are null. It would be helpful to show the test environment is somehow messed up, instead of having a dev start digging through the test/modules
| @@ -4,7 +4,8 @@ | |||
| vcenter_cluster_name: "Eco-Cluster" | |||
| vcenter_datacenter: "Eco-Datacenter" | |||
| vcenter_port: 443 | |||
| rhel_9_3_iso_path: "[eco-nfs-datastore-iso] rhel-9.3-x86_64-dvd.iso" | |||
| rhel_9_3_iso_path: "[eco-nfs-datastore-iso] rhel-9.3-x86_64-boot.iso" | |||
There was a problem hiding this comment.
Tzach made a content library with these ISOs that might be better long term than the NFS datastore.
Theres also a content library dedicated to testing resources I set up for vmware.vmware, ansible_ci_resources or something like that. We could add these ISOs there
| source ../init-eco.sh | ||
|
|
||
| # Generates a string starting with 'test-' followed by 4 random lowercase characters | ||
| TINY_PREFIX="test-$(uuidgen | tr -d '-' | cut -c1-4 | tr '[:upper:]' '[:lower:]')" |
There was a problem hiding this comment.
| TINY_PREFIX="test-$(uuidgen | tr -d '-' | cut -c1-4 | tr '[:upper:]' '[:lower:]')" | |
| TINY_PREFIX="test-vmware_rest-$(uuidgen | tr -d '-' | cut -c1-4 | tr '[:upper:]' '[:lower:]')" |
Since we have 3 repos making test resources, we could differentiate the prefix so we know from where the resources are coming
There was a problem hiding this comment.
this file is referenced here: https://github.com/ansible-collections/vmware.vmware_rest/blob/main/development.md#optional-update-the-return-block-of-the-vmware-modules-using-the-test-suite
I think we can delete that whole section of the docs. It does more harm than good and now this file is being removed
There was a problem hiding this comment.
I'll add to the new PR to clean up all outdated tests
anna-savina
force-pushed
the
modify_vcenter_vm_scenario1_test
branch
from
88930ed to
bc31d38
Compare
anna-savina
force-pushed
the
modify_vcenter_vm_scenario1_test
branch
from
bc31d38 to
5e69946
Compare
anna-savina
force-pushed
the
modify_vcenter_vm_scenario1_test
branch
from
5e69946 to
b46e137
Compare
Modified vcenter_vm_scenario1 test target to run on the eco vsphere env