fix(netconf_config.py): type conversion issue for confirm_timeout #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voici un message de commit clair et concis pour ton pull request : Ensure confirm_timeout is correctly converted to a string using `to_text()` to prevent type mismatches. This resolves errors like `Argument must be bytes or unicode, got 'int'` when using commit confirmation. Change applied in line 669: - `confirmed=confirmed_commit, timeout=confirm_timeout` + `confirmed=confirmed_commit, timeout=to_text(confirm_timeout, errors='surrogate_or_strict')`
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request fixes a type conversion issue in the
netconf_configmodule of theansible.netcommoncollection.When using the
confirmparameter, Ansible throws an error due to a type mismatch:This occurs because
confirm_timeout, which is expected to be an integer, is not properly converted before being passed to the NETCONF commit operation.The fix ensures
confirm_timeoutis explicitly converted to a string usingto_text()witherrors='surrogate_or_strict'before passing it to the commit operation.Fixes #551
ISSUE TYPE
COMPONENT NAME
ansible.netcommon.netconf_configADDITIONAL INFORMATION
The issue occurs when attempting to use
confirminansible.netcommon.netconf_config, leading to a failure due to incorrect type handling.Code Change (Line 669 of
netconf_config.py):This fix ensures proper type handling and allows users to correctly perform confirmed commits with rollback timers.
References:
Let me know if any further modifications are required! 🚀