QuantityFormatterTests: Formatting the 'expected' values using the CurrentUICulture #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrentUICulture - var expected = string.Format(CultureInfo.CurrentUICulture, ...) as per the defaultCulture of the QuantityFormatter.Format method overload
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 281 281
Lines 41925 41925
=======================================
Hits 33770 33770
Misses 8155 8155 Continue to review full report at Codecov.
|
|
Thanks! We'll revisit in #795. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS This might have to get reverted after #795 is merged, but I suggest updating this so that it is consistent with the currently tested behavior (there are currently 17 tests failing on my machine)