Add mega force and torque #342
Conversation
|
Thanks I'm glad you appreciate it and that you decided to help out improving it! |
CGrisselin
changed the title
|
Glad you haven't time to do it too fast. I just saw that in pounds units doesn't show up (AbbreviationsWithPrefixes are missing). I fix it and commit asap. |
| "Localization": [ | ||
| { | ||
| "Culture": "en-US", | ||
| "Abbreviations": [ "lbf·in" ], | ||
| "AbbreviationsWithPrefixes": [ "kipf·in" ] | ||
| "AbbreviationsWithPrefixes": [ "kipf·in", "Mlbf·in"] |
There was a problem hiding this comment.
It seems to me that kipf or kip is a special case of widely used abbreviations although it "should" have been named klbf·in for consistency. Unfortunately the current code generator doesn't support multiple units per prefix, so we have to choose one and I won't change it now to avoid breaking anything. I'm creating a new issue to address the need to support multiple abbreviations for prefixed units so we can add it later. See #344
You don't have to take any action in this PR, this is just an observation on my part.
Hi Andreas,
First of all, thank you very much for your wonderful work with UnitsNet. It is really helpful!
I need for one of my project bigger units for torques and forces. I have followed your instruction to add them and send you this mergerequest.
I am a beginner with github so tell me if I have done something wrong.
Best regards,
Christophe