Decompose unit conversion functions to exact coefficients (non-breaking) #1498
Conversation
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
There was a problem hiding this comment.
I'll go ahead and merge this, just one minor comment/suggestion.
Tons of great work here 👏
I only skimmed the new constants though and spot tested a few places, but I have not verified every single change since it seems the tests still pass and that is a good indicator things are in order.
| "FromUnitToBaseFunc": "{x} * Math.Pow(2.54e-2, 6)", | ||
| "FromBaseToUnitFunc": "{x} / Math.Pow(2.54e-2, 6)", | ||
| "FromUnitToBaseFunc": "{x} * 0.000000000268535866540096", | ||
| "FromBaseToUnitFunc": "{x} / 0.000000000268535866540096", |
There was a problem hiding this comment.
In a way, I kind of prefer the Math.Pow formula, since it is easier to recognize the constant 2.54 and even repeating it 6 times 2.54e-2 * 2.54e-2 * ... could be one option if Math.Pow throws a curveball.
I have no strong opinion here, just an observation.
There was a problem hiding this comment.
I can work with Math.Pow as well, but if we (or whoever) wanted to created a generator for another language, the uses of Math means more hoops to deal with..
…tions with exact coefficients (non-breaking)
angularsen
force-pushed
the
unit-conversion-expressions-v6
branch
from
0d23892 to
e4f6e62
Compare
angularsen
changed the title
angularsen
changed the title
This is a port of #1393, targeting the
release-v6consisting of the changes that didn't require any modifications to the tests.I'll create another PR with the rest of the (breaking) changes in a bit.