Skip to content

fix(chromedriver): get most recent version on x64 windows if multiple major versions exist #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Blackbaud-BobbyEarl
Copy link
Contributor

@Blackbaud-BobbyEarl Blackbaud-BobbyEarl commented Sep 2, 2020

Attempt to fix #472 - with more context specifically at #472 (comment)

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Sep 2, 2020
@lotz
Copy link
Contributor

lotz commented Sep 2, 2020

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Sep 2, 2020
@Blackbaud-BobbyEarl
Copy link
Contributor Author

Hey @cnishina! You seem to be an active contributor to this repository and were the last to make a commit.

Do you think this PR is something you could help champion through or direct to the right person?

Thanks for any help!

@sbley
Copy link

sbley commented Sep 4, 2020

Who else would be authorized to merge this pull request? Is there a list of authorized contributers somewhere?

@cnishina cnishina merged commit 4f5f736 into angular:legacy Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloading wrong version of Chromedriver
5 participants