Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to latest next version and remove patch #30809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: update to latest next version and remove patch #30809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
# This file should be checked into version control along with the pnpm-lock.yaml file.
.npmrc=-1406867100
integration/package.json=-620011313
package.json=20540807
patches/@angular__compiler-cli.patch=-65319555
pnpm-lock.yaml=-1601778403
package.json=1694791683
pnpm-lock.yaml=-609363675
pnpm-workspace.yaml=334858811
src/cdk-experimental/package.json=237487315
src/cdk/package.json=-908433069
Expand All @@ -20,4 +19,4 @@ src/material-moment-adapter/package.json=-1407689629
src/material/package.json=-1237533685
src/universal-app/package.json=346715231
src/youtube-player/package.json=68300461
yarn.lock=230420156
yarn.lock=-710001387
1 change: 0 additions & 1 deletion WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ npm_translate_lock(
},
data = [
"//:package.json",
"//:patches/@angular__compiler-cli.patch",
"//:pnpm-workspace.yaml",
"//integration:package.json",
"//src/cdk:package.json",
Expand Down
35 changes: 16 additions & 19 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@
},
"version": "20.0.0-next.5",
"dependencies": {
"@angular/animations": "^20.0.0-next.4",
"@angular/common": "^20.0.0-next.4",
"@angular/compiler": "^20.0.0-next.4",
"@angular/core": "^20.0.0-next.4",
"@angular/forms": "^20.0.0-next.4",
"@angular/platform-browser": "^20.0.0-next.4",
"@angular/animations": "^20.0.0-next.5",
"@angular/common": "^20.0.0-next.5",
"@angular/compiler": "^20.0.0-next.5",
"@angular/core": "^20.0.0-next.5",
"@angular/forms": "^20.0.0-next.5",
"@angular/platform-browser": "^20.0.0-next.5",
"@types/google.maps": "^3.54.10",
"@types/youtube": "^0.1.0",
"date-fns": "^4.1.0",
Expand All @@ -71,18 +71,18 @@
"zone.js": "~0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^20.0.0-next.3",
"@angular-devkit/core": "^20.0.0-next.3",
"@angular-devkit/schematics": "^20.0.0-next.3",
"@angular-devkit/build-angular": "^20.0.0-next.4",
"@angular-devkit/core": "^20.0.0-next.4",
"@angular-devkit/schematics": "^20.0.0-next.4",
"@angular/bazel": "https://github.com/angular/bazel-builds.git#54a0ac1bc77b58214a1c4d3cdcf167676ea621e4",
"@angular/build": "^20.0.0-next.3",
"@angular/build": "^20.0.0-next.4",
"@angular/build-tooling": "https://github.com/angular/dev-infra-private-build-tooling-builds.git#ec9df12469082e3cb087a9af55072dc2d833c73f",
"@angular/cli": "^20.0.0-next.3",
"@angular/compiler-cli": "^20.0.0-next.4",
"@angular/localize": "^20.0.0-next.4",
"@angular/cli": "^20.0.0-next.4",
"@angular/compiler-cli": "^20.0.0-next.5",
"@angular/localize": "^20.0.0-next.5",
"@angular/ng-dev": "https://github.com/angular/dev-infra-private-ng-dev-builds.git#1fa3a08b6a111de820da092799319ed47c058849",
"@angular/platform-server": "^20.0.0-next.4",
"@angular/router": "^20.0.0-next.4",
"@angular/platform-server": "^20.0.0-next.5",
"@angular/router": "^20.0.0-next.5",
"@babel/core": "^7.16.12",
"@babel/helper-explode-assignable-expression": "^7.18.6",
"@babel/helper-string-parser": "^7.22.5",
Expand All @@ -102,7 +102,7 @@
"@octokit/rest": "18.3.5",
"@rollup/plugin-commonjs": "^21.0.0",
"@rollup/plugin-node-resolve": "^13.1.3",
"@schematics/angular": "^20.0.0-next.3",
"@schematics/angular": "^20.0.0-next.4",
"@types/babel__core": "^7.1.18",
"@types/browser-sync": "^2.26.3",
"@types/fs-extra": "^9.0.13",
Expand Down Expand Up @@ -185,9 +185,6 @@
},
"pnpm": {
"onlyBuiltDependencies": [],
"patchedDependencies": {
Copy link
Member Author

@crisbeto crisbeto Apr 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devversion not sure if it's because I removed this, but it actually ends up breaking at runtime with the following error:

Error: The injectable '_PlatformLocation' needs to be compiled using the JIT compiler, but '@angular/compiler' is not available.

The injectable is part of a library that has been partially compiled.
However, the Angular Linker has not processed the library such that JIT compilation is used as fallback.

Ideally, the library is processed using the Angular Linker to become fully AOT compiled.
Alternatively, the JIT compiler should be loaded by bootstrapping using '@angular/platform-browser-dynamic' or '@angular/platform-server',
or manually provide the compiler with 'import "@angular/compiler";' before bootstrapping.

It looks like something isn't being compiled. I got this error from bazel test //src/universal-app:prerender_test, but the dev app breaks with something similar at runtime.

"@angular/[email protected]": "patches/@angular__compiler-cli.patch"
},
"packageExtensions": {
"dgeni-packages": {
"dependencies": {
Expand Down
13 changes: 0 additions & 13 deletions patches/@angular__compiler-cli.patch
View file
Open in desktop

This file was deleted.

Loading
Loading