Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(youtube-player): use safevalues #30773

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(youtube-player): use safevalues #30773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
263a400
fix(youtube-player): use safevalues
andrewseguin Apr 2, 2025
69e9756
fix(youtube-player): add safevalues to package externals
andrewseguin Apr 2, 2025
353584c
fix(youtube-player): add safevalues to package externals
andrewseguin Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .aspect/rules/external_repository_action_cache/npm_translate_lock_MzA5NzUwNzMx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Input hashes for repository rule npm_translate_lock(name = "npm2", pnpm_lock = "@//:pnpm-lock.yaml").
# This file should be checked into version control along with the pnpm-lock.yaml file.
.npmrc=-1406867100
package.json=130765121
package.json=441060861
patches/@angular__compiler-cli.patch=-65319555
pnpm-lock.yaml=-266832367
pnpm-lock.yaml=1755183230
pnpm-workspace.yaml=14857322
src/cdk/package.json=-908433069
yarn.lock=230420156
yarn.lock=-1568260908
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
"rxjs": "^6.6.7",
"rxjs-tslint-rules": "^4.34.8",
"tslib": "^2.3.1",
"zone.js": "~0.15.0"
"zone.js": "~0.15.0",
"safevalues": "^1.2.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^20.0.0-next.3",
Expand Down
2 changes: 2 additions & 0 deletions pkg-externals.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ PKG_EXTERNALS = [
"rxjs",
"rxjs/operators",
"selenium-webdriver",
"safevalues",
"safevalues/dom",
]

# Creates externals for a given package and its entry-points.
Expand Down
3,954 changes: 1,981 additions & 1,973 deletions pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/youtube-player/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ ng_project(
"//:node_modules/@angular/core",
"//:node_modules/@types/youtube",
"//:node_modules/rxjs",
"//:node_modules/safevalues",
"//src:dev_mode_types",
],
)
Expand Down
3 changes: 2 additions & 1 deletion src/youtube-player/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"homepage": "https://github.com/angular/components/tree/main/src/youtube-player#readme",
"dependencies": {
"@types/youtube": "^0.1.0",
"tslib": "^2.3.0"
"tslib": "^2.3.0",
"safevalues": "^1.2.0"
},
"peerDependencies": {
"@angular/core": "0.0.0-NG",
Expand Down
6 changes: 4 additions & 2 deletions src/youtube-player/youtube-player.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ import {
EventEmitter,
} from '@angular/core';
import {isPlatformBrowser} from '@angular/common';
import {trustedResourceUrl} from 'safevalues';
import {setScriptSrc} from 'safevalues/dom';
import {Observable, of as observableOf, Subject, BehaviorSubject, fromEventPattern} from 'rxjs';
import {takeUntil, switchMap} from 'rxjs/operators';
import {PlaceholderImageQuality, YouTubePlayerPlaceholder} from './youtube-player-placeholder';
Expand Down Expand Up @@ -743,7 +745,7 @@ function loadApi(nonce: string | null): void {
}

// We can use `document` directly here, because this logic doesn't run outside the browser.
const url = 'https://www.youtube.com/iframe_api';
const url = trustedResourceUrl`https://www.youtube.com/iframe_api`;
const script = document.createElement('script');
const callback = (event: Event) => {
script.removeEventListener('load', callback);
Expand All @@ -759,7 +761,7 @@ function loadApi(nonce: string | null): void {
};
script.addEventListener('load', callback);
script.addEventListener('error', callback);
(script as any).src = url;
setScriptSrc(script, url);
script.async = true;

if (nonce) {
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12963,6 +12963,11 @@ safe-stable-stringify@^2.3.1:
resolved "https://registry.yarnpkg.com/safer-buffer/-/safer-buffer-2.1.2.tgz#44fa161b0187b9549dd84bb91802f9bd8385cd6a"
integrity sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==

safevalues@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/safevalues/-/safevalues-1.2.0.tgz#f9e646d6ebf31788004ef192d2a7d646c9896bb2"
integrity sha512-zIsuhjYvJCjfsfjoim2ab6gLKFYAnTiDSJGh0cC3T44L/4kNLL90hBG2BzrXPrHA3f8Ms8FSJ1mljKH5dVR1cw==

[email protected]:
version "16.0.5"
resolved "https://registry.yarnpkg.com/sass-loader/-/sass-loader-16.0.5.tgz#257bc90119ade066851cafe7f2c3f3504c7cda98"
Expand Down
Loading