fix(cdk-experimental/listbox): ignore spaces during typeahead #30766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagnermaciel
added
the
target: major
wagnermaciel
force-pushed
the
listbox-typeahead
branch
from
088bceb to
7834956
Compare
wagnermaciel
requested review from
crisbeto and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Apr 10, 2025
| @@ -91,6 +91,9 @@ export class ListboxPattern<V> { | |||
| return this.inputs.textDirection() === 'rtl' ? 'ArrowLeft' : 'ArrowRight'; | |||
| }); | |||
|
|
|||
| /** Represents the space key. Does nothing when the user is actively using typeahead. */ | |||
| spaceKey = computed(() => (this.typeahead.query().length ? '' : ' ')); | |||
There was a problem hiding this comment.
how about something like spaceSelectionKey, or something similar, to imply there's more to it than just watching spaceKey?
Below the logic just seems to always trigger on "space key"
There was a problem hiding this comment.
or should this just generally be selectionKey and include the 'Enter' key in this
There was a problem hiding this comment.
We wouldn't be able to include "Enter" unless we change the event manager to also accept Signal. Imo the fact that we're using a signal instead of just the character " " already indicates there's more going on here, but I updated the name to "dynamicSpaceKey" anyway
src/cdk-experimental/ui-patterns/behaviors/list-typeahead/list-typeahead.ts
Outdated
Show resolved
Hide resolved
wagnermaciel
force-pushed
the
listbox-typeahead
branch
from
fe84f96 to
bc750a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.