-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/chips): chips form control updating value immediately #30694
base: main
Are you sure you want to change the base?
fix(material/chips): chips form control updating value immediately #30694
Conversation
8393040
to
3496154
Compare
Currently, when we have chips with form control, the value is updated only when its focused out. This fix will update the value of form control immediately Fixes angular#28065
3496154
to
eb7ee2b
Compare
My only worry with that is that people are probably programmatically accessing the |
So, as of now we won't be doing any input signal migration now. But if there is some decision on that to migrate one by one with breaking change note I can contribute a bit for smaller component atleast. |
@mistrykaran91 sure, thanks for volunteering! I'll definitely let you know if there's a chance to help with that |
FYI this breaks a handful of tests in google, We'll need to investigate and determine if the issue is just with brittle tests or something with the change itself. |
Let me know if this change does not work, I at-least think this is the place but you can let me know if its because of the change I can revisit. |
Currently, when we have chips with form control, the value is updated only when its focused out. This fix will update the value of form control immediately
Fixes #28065