Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): always disable JSON stats with dev-server #29707

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Feb 25, 2025

When using the development server, the statsJson option will now unconditionally be disabled. The output JSON file is not accessible with the server and the analysis/generation of the JSON file may increase the rebuild time. Additionally, the JSON file changes during a rebuild may unexpectedly cause component HMR fallback to a full reload due to non-component file changes in the build output.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Feb 25, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 25, 2025
@clydin clydin requested a review from dgp1130 February 25, 2025 16:15
When using the development server, the `statsJson` option will now
unconditionally be disabled. The output JSON file is not accessible
with the server and the analysis/generation of the JSON file may
increase the rebuild time. Additionally, the JSON file changes during
a rebuild may unexpectedly cause component HMR fallback to a full
reload due to non-component file changes in the build output.
@clydin clydin force-pushed the dev/disable-stats-json branch from fb14c14 to 055d972 Compare February 25, 2025 17:54
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 25, 2025
@clydin clydin merged commit eb058d0 into angular:main Feb 25, 2025
31 checks passed
@clydin
Copy link
Member Author

clydin commented Feb 25, 2025

The changes were merged into the following branches: main, 19.1.x, 19.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants