feat(choices): allow user select group header

[DarkIsDude]

User can now select header of group by option to select all item in this group

#1074 old pull request ref

[Jefiozie]

Can we make a seperate attribute directive for this?
As the uiSelectController already has a lot of functionality in the code i would like to separate some additional features vs the core functionality. Second I think there needs to be some tests made and a working example plunker so that i can have a look at it.

[randdusing]

It would also be nice if the keyboard navigation supported this as well

[DarkIsDude]

Hi, we will use it in production. I must complete some task then I will changes this PR.

[DarkIsDude]

@Jefiozie thanks for your review. I just push a new commit to create a new directive (ui-select-header-group-selectable) that must be added on ui-select-choices directive with multiple and groups check.

It's my first PR, just say me if I must improve something.
You can find two comment

• Don't know why I must do this:
  var $select = select[0];
• And if it's the good way to find the group:
  var group = $select.findGroupByName(element.text(), true);

How can I create a plunker with my repo to show the result? How can I insert my select.js and select.css?

@randdusing I don't know where I can find the code that catch up keyboard event... Can you help me?

[randdusing]

I've heard this library is completely dead... so may not be worth investing time into a PR. I'm not exactly sure where the general keyboard handling is, but maybe try to find where DOWN is referenced.

[Jefiozie]

You can use the examples plunkers to fork the default ui-select example. Next copy your local build select.js etc in it and share the url.

The keyboard codes are in the common.js

[DarkIsDude]

@Jefiozie here the plunker: http://plnkr.co/edit/Ujr9amwp3hYMHwSgNdMT?p=preview to try it.
For the keyboard, it's a little bit more complicated. Maybe I will try it in an another PR.

Is it ok for you?

[Klinton90]

Just small request: can we make it optional? I.e. scope: {isEnabled: "<uiSelectHeaderGroupSelectable"}.

[DarkIsDude]

@Klinton90 the new plunker with your option: http://plnkr.co/edit/xtJ0SEGneWijtkc06hw5?p=preview.

@Jefiozie why the build fail?

[Klinton90]

Many thanks!

[kprabhuvel]

@DarkIsDude.. Even, I need this feature in my application. When do you think you can resolve and have a PR ready? Do you have a timeline when will it be ready? Please let me know.
-Prabhu

[Jefiozie]

@DarkIsDude Could you change something to test the build? Place the brackets on line 3195 and place it on line 3203

I cannot reproduce it but it looks a bit off. (but maybe its just me 😄

[DarkIsDude]

@kprabhuvel, I work on it when I can, it's not a priority in our team...
I hope it will be ready soon but the build fail and I don't know why... @Jefiozie do you have an idea?

[Jefiozie]

@DarkIsDude no I don't know why it does this. Merged other PR yesterday wasn't any problem there. Looks like something is breaking for Firefox as it doesn't start.

[DarkIsDude]

So bad :( ... I just run gulp test on Firefox:
browsers: ['Firefox'],
on line 43 in karma.conf.js

And all pass... I don't know how can I fix it. Someone can help me?

[Jefiozie]

Hi @DarkIsDude could you merge the master in your branch and see if the issue is fixed?
Thanks

[DarkIsDude]

@Jefiozie yeah!!! It works. Well done. I'm waiting this PR is merged and after I will work on the keyboard navigation.

[Jefiozie]

Hi @DarkIsDude ,

Could you add a small part on the wiki that this is working from the upcoming version?
LGTM 👍

[DarkIsDude]

@Jefiozie did it ;).

[Klinton90]

Found couple related issues. PR is #2069
It would be nice if @DarkIsDude can review my changes in case I broke something.

[swarnakarraj]

when you have On-select function defined for ui-select. It gets triggered for each item when you click on group.