Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement | Bandwidth limiter for network plugin #269

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

snehilrx
Copy link

@snehilrx snehilrx commented Sep 1, 2023

Hi @srtvprateek,

This pr adds bandwidth / speed limit feature to the network plugin. The change includes setting up

  1. Upload speed / bandwidth limit - By throttling the output stream of socket
  2. Download speed / bandwidth limit - By throttling the input stream of socket
  3. Delay in DNS Resolution (happens when connection is opened once)

By introducing upload and download speed limits, as well as the ability to simulate delays in DNS resolution, this PR empowers users to recreate real-world network conditions.

@srtvprateek
Copy link
Member

srtvprateek commented Sep 12, 2023

hey @snehilrx ,
thanks for the contribution,
but since we follow plugin architecture, the changes regarding the plugin should be encapsulated within the plugin itself.

Also see if the same settings can be used for other interceptors also.

  • Can you also attach a video for the implementation?

@artemyto
Copy link
Contributor

DataBinding is in maintenance mode and Google is not recommend to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants