Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test fixtures and migrate datastore test setup #1834

Closed

Conversation

emartynov
Copy link

@emartynov emartynov commented Mar 1, 2025

What I have done

I've enabled Kotlin test fixtures and converted test-related modules to test fixtures:

  1. Added flag in gradle.properties
  2. Configured test fixtures in feature module
  3. Moved code from the test module to the test fixtures folder in the feature module
  4. Replaced all references from test module with test fixtures from feature module
  5. Deleted the test module

Why

I believe test fixtures have two advantages from the test module:

  1. It doesn't need to be a separate module, and the test fixture code lies close to the definition of dependency that needs to be set in tests.
  2. Not for this change, but test fixtures have access to internal code in the module, making the public module API cleaner and smaller.

Further changes

  • Put official documentation about the feature.
  • Migrate a couple of other test-related modules to test fixtures.

@SimonMarquis
Copy link
Contributor

FYI some work was already been done in:

But we are waiting on the maintainers feedback here and there

@emartynov
Copy link
Author

Ah, I didn't notice it, sorry! Let me see PRs.

And I think I will close it.

@emartynov
Copy link
Author

Closing since there is full set in #1515

@emartynov emartynov closed this Mar 1, 2025
@emartynov emartynov deleted the eugen/test-fisture-introduction branch March 3, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants