Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting the old value in deep watching #4406

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix getting the old value in deep watching #4406

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3885db
Fix getting the old value in deep watching
Suall1969 Oct 19, 2024
64b091a
Add test
Suall1969 Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/alpinejs/src/reactivity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ export function elementBoundEffect(el) {
}

export function watch(getter, callback) {
const deepClone = obj => "structuredClone" in globalThis ? structuredClone(obj) : obj

let firstTime = true

let oldValue
Expand All @@ -73,10 +75,10 @@ export function watch(getter, callback) {
queueMicrotask(() => {
callback(value, oldValue)

oldValue = value
oldValue = deepClone(raw(value))
})
} else {
oldValue = value
oldValue = deepClone(raw(value))
}

firstTime = false
Expand Down