Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make docs more generic to package managers #4310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

browner12
Copy link
Contributor

for a long time NPM has basically been the de facto front end package manager. however, BunJS is making a strong push, and a good case for itself, so I think it'd be good for us to include it where appropriate.

we all know specific tooling comes and goes, so I've made the language more generic where appropriate, and refer to "a package manager" instead of specifically "NPM".

I've also then included the analogous bun command next to npm commands.

for a long time NPM has basically been the de facto front end package manager. however, BunJS is making a strong push, and a good case for itself, so I think it'd be good for us to include it where appropriate.

we all know specific tooling comes and goes, so I've made the language *more generic* where appropriate, and refer to "a package manager" instead of specifically "NPM".

I've also then included the analogous `bun` command next to `npm` commands.
@ekwoka
Copy link
Contributor

ekwoka commented Jul 22, 2024

pnpm would probably be a more important add, since it's the current most common standard for basically everything (and directly supported everywhere). Bun is new but much less common and not supported many places without extra code (cloudflare auto detects)

@browner12
Copy link
Contributor Author

I'm definitely okay with adding others, if you want to do a separate PR after/if this one gets merged.

I still think it's important to make the appropriate parts of the documentation language "tool agnostic".

What do you mean by "bun is not supported many places"? It's a binary that can be installed with a simple bash script.

@ekwoka
Copy link
Contributor

ekwoka commented Jul 22, 2024

What do you mean by "bun is not supported many places"? It's a binary that can be installed with a simple bash script.

I mean naturally. Like auto-detected, preinstalled.

I'm definitely okay with adding others, if you want to do a separate PR after/if this one gets merged.

Probably better just to do it all in one, tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants