-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove GOVUKFrontend
prefix from GOVUKFrontendComponent
#5515
Merged
+148
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for ab05f56 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
6f9861d
to
de5e37a
Compare
de5e37a
to
d5f9b5d
Compare
d5f9b5d
to
2c540fa
Compare
2c540fa
to
4d6727b
Compare
4d6727b
to
675b7fb
Compare
675b7fb
to
40fef81
Compare
GOVUKFrontend
prefix from GOVUKFrontendComponent
and GOVUKFrontendComponentConfigurable
720689c
to
8b2650b
Compare
8b2650b
to
03d0100
Compare
59adefb
to
5b8a20c
Compare
5b8a20c
to
9f13658
Compare
9f13658
to
bcce2be
Compare
romaricpascal
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reworking the history, looks good to go! 🙌🏻 ⛵
95eb0d4
to
b1f2bf7
Compare
b1f2bf7
to
ab14a65
Compare
ab14a65
to
62a971c
Compare
- `GOVUKFrontendComponent` is now `Component`. Renamed `govuk-frontend-component.mjs` to `component.mjs` and the associated test. Changed references to `GOVUKFrontendComponent` to `Component` in the test.
Components that extended `GOVUKFrontendComponent` now extend `Component` from `component.mjs`.
79b4486
to
df5766a
Compare
owenatgov
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤙🏻
seaemsi
reviewed
Feb 11, 2025
seaemsi
reviewed
Feb 11, 2025
seaemsi
reviewed
Feb 11, 2025
seaemsi
reviewed
Feb 11, 2025
seaemsi
reviewed
Feb 11, 2025
Because they're not imported by `all.mjs` deprecated JavaScript files were not included in the package (in which they need to remain until the next breaking release). This adds a module to store the list of deprecated JavaScript files and helper functions that are then used: - in the Gulp configuration, to add a new task building each deprecated file individually - in the Rollup configuration, to prevent the bundled output of the deprecated files as all we want is for them to be in the package as a module Add new section to documentation `Managing Change` which details the process of marking a JS file for deprecation. Co-authored-by: Patrick Cartlidge <[email protected]> Co-authored-by: Brett Kyle <[email protected]> Co-authored-by: seaemsi <[email protected]>
`compile:js 'deprecations'` now will only run if there are files present in the `deprecatedFilesPaths` array.
ed8657a
to
ab05f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
GOVUKFrontend
prefix fromComponent
Component
ConfigurableComponent
to extendComponent
dist
folder after the build process, thus avoiding a breaking change in any PR)Managing Change
Why
Fixes #5497