Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml docs and input parameter's nullability fix #249

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

DeadUnicorn1352
Copy link

Description

This pr fixes a constructor parameter "filter" of GridifyQuery. It is 'string' even though property is 'string?' in nullable context passing null creates a warning (and is in general confusing), but passing empty string will fail QueryBuilder.BuildEvaluator().

Also some XML documentation had issues which in term broke documentation in rider, also fixed that.

I haven't created an issue for that

Type of change

  • xml documentation and parameter nullability

Copy link

what-the-diff bot commented Feb 6, 2025

PR Summary

  • Correction to XML Documentation in GridifyExtensions.cs

    • XML Documentation comments have been updated to correct the syntax for generic placeholders. This corrects the way types are presented and makes the documentation clearer and more accurate.
  • Change to GridifyQuery Constructor in GridifyQuery.cs

    • Modification has been made to the GridifyQuery constructor to accept a nullable string for the filter parameter. This change enhances how inputs are handled, providing more flexibility when declaring the filter parameter.

Copy link
Owner

@alirezanet alirezanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌💐

@alirezanet alirezanet merged commit 8ac59c7 into alirezanet:master Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants