xml docs and input parameter's nullability fix #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes a constructor parameter "filter" of GridifyQuery. It is 'string' even though property is 'string?' in nullable context passing null creates a warning (and is in general confusing), but passing empty string will fail QueryBuilder.BuildEvaluator().
Also some XML documentation had issues which in term broke documentation in rider, also fixed that.
I haven't created an issue for that
Type of change