-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): add destroy method, close #1363 #1742
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docsearch canceled.
|
I am unfamilar with react, preact so I am not sure if this is correct, maintainers should pay sepecial attention to my code, thanks. Since preact returns void when rendering (or "mounting") a component to dom, I make a hacky way to trigger it's unmount lifecycle. And I saw that key listeners with side effects will clear effect when it's being unmounted from BTW, when runing
|
👷 Deploy request for docsearch pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mister-Hope I know this PR has been sitting for awhile now, but it doesn't seem like this is the correct approach to fixing the issue. A Preact hook has to be used within a Preact component but docsearch is just a wrapper function we expose for being able to render.
No description provided.