V2: Replace singly linked lists with Set objects #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE
To avoid duplicated side effects, `EventEmitter` subclasses that override the `[$addListener]` method should only apply side effects when a single function is passed. BREAKING CHANGE
Use the exported `$listeners` symbol, instead. BREAKING CHANGE
src/types.ts
Outdated
| export type EventIn<T, K extends EventKey<T>> = Id<In<T[K]>> | ||
| export type EventOut<T, K extends EventKey<T>> = Id<Out<T[K]> | void> | ||
| /** Extract an array type of valid event keys */ | ||
| export type EventKey<T> = keyof T & string |
There was a problem hiding this comment.
qq: Are you removing support for output values in v2?
There was a problem hiding this comment.
Sort of. You'll still be able to use getListeners with Array.from like this:
const results = Array.from(ee.getListeners('key'), fn => fn())Note: getListeners of v2 is not equivalent to listeners of v1. The former returns a Set of listeners, the latter returns an iterable.
The "*" key is reserved for removing the listeners of all events, like this:
ee.on("test", () => {})
ee.off("*")
ee.getListeners("test").size // => 0
To make your EventEmitter readonly, cast it as an EventSource.
You cannot freeze a Set object like that. lol
or else some bundlers complain
You can use `ee.getListeners()` instead
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage ? 94.87%
=========================================
Files ? 1
Lines ? 39
Branches ? 15
=========================================
Hits ? 37
Misses ? 2
Partials ? 0
Continue to review full report at Codecov.
|
Pass another `EventSource` or `EventEmitter` type as the type parameter of the `EventSource` type to use the same events. Useful for converting an `EventEmitter` to an `EventSource`, as well as omitting properties not related to events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.