Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddNewlineAction.py: A new action for GitCommitBear #1

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

akshatkarani
Copy link
Owner

This passes actions list as a argument when yielding a
Result when there is no new line between shortlog and
body of the commit message.

@akshatkarani akshatkarani force-pushed the add-newline-action branch 6 times, most recently from f58a894 to 245ca22 Compare June 16, 2019 10:58
new_commit_message = '{}\n\n{}'.format(self.shortlog, self.body)
command = 'git commit --amend -m "{}"'.format(new_commit_message)
stdout, err = run_shell_command(command)
file_diff_dict['AddNewlineAction'] = True
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using file_diff_dict to know when this action is applied. This is required to know if action is applicable or not.

@akshatkarani akshatkarani changed the title CommitBear.py: Pass actions list when yielding Result AddNewlineAction.py: A new action for GitCommitBear Jun 16, 2019
@akshatkarani akshatkarani force-pushed the add-newline-action branch 2 times, most recently from 66aa2cb to eda00ac Compare June 18, 2019 11:20
@akshatkarani akshatkarani force-pushed the add-newline-action branch 6 times, most recently from 487c946 to 4cb2747 Compare June 26, 2019 05:53
@akshatkarani akshatkarani force-pushed the add-newline-action branch 2 times, most recently from 51e9f5e to bd53589 Compare June 29, 2019 11:24
@akshatkarani akshatkarani force-pushed the add-newline-action branch 5 times, most recently from b15ec55 to 4c5c866 Compare July 22, 2019 09:30
@akshatkarani akshatkarani force-pushed the add-newline-action branch 4 times, most recently from 8b28fcc to 675cc1e Compare August 13, 2019 15:25
@akshatkarani akshatkarani force-pushed the add-newline-action branch 3 times, most recently from 24f27bc to d9a5df2 Compare September 4, 2019 07:01
@akshatkarani akshatkarani force-pushed the add-newline-action branch 2 times, most recently from bc41a68 to 892e753 Compare September 8, 2019 05:06
abhishalya and others added 6 commits July 19, 2020 11:22
This extends the commit over
coala#2975
and uses a compatible version of codecov
to be able to upload report to s3.
This updates the bandit version to fix
the dependency issue and to fix coala
installation.

Closes coala#2985
This adds a new action for GitCommitBear. When applied it
opens up a editor for user to edit commit message of the HEAD commit.
This also makes changes is CommitBear.py to pass EditCommitMessageAction
when Result is yielded.
This adds a new action which adds a newline between
shortlog and body of commit message when applied.
This also make changes in CommitBear.py to pass
AddNewlineAction when Result is yielded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants