forked from coala/coala-bears
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddNewlineAction.py: A new action for GitCommitBear #1
Open
akshatkarani
wants to merge
7
commits into
master
Choose a base branch
from
add-newline-action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshatkarani
force-pushed
the
add-newline-action
branch
6 times, most recently
from
June 16, 2019 10:58
f58a894
to
245ca22
Compare
akshatkarani
commented
Jun 16, 2019
bears/actions/AddNewlineAction.py
Outdated
new_commit_message = '{}\n\n{}'.format(self.shortlog, self.body) | ||
command = 'git commit --amend -m "{}"'.format(new_commit_message) | ||
stdout, err = run_shell_command(command) | ||
file_diff_dict['AddNewlineAction'] = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using file_diff_dict
to know when this action is applied. This is required to know if action is applicable or not.
akshatkarani
changed the title
CommitBear.py: Pass actions list when yielding Result
AddNewlineAction.py: A new action for GitCommitBear
Jun 16, 2019
akshatkarani
force-pushed
the
add-newline-action
branch
2 times, most recently
from
June 18, 2019 11:20
66aa2cb
to
eda00ac
Compare
akshatkarani
force-pushed
the
add-newline-action
branch
6 times, most recently
from
June 26, 2019 05:53
487c946
to
4cb2747
Compare
akshatkarani
force-pushed
the
add-newline-action
branch
2 times, most recently
from
June 29, 2019 11:24
51e9f5e
to
bd53589
Compare
akshatkarani
force-pushed
the
add-newline-action
branch
from
July 8, 2019 06:46
bd53589
to
00a3374
Compare
akshatkarani
force-pushed
the
add-newline-action
branch
5 times, most recently
from
July 22, 2019 09:30
b15ec55
to
4c5c866
Compare
akshatkarani
force-pushed
the
add-newline-action
branch
4 times, most recently
from
August 13, 2019 15:25
8b28fcc
to
675cc1e
Compare
akshatkarani
force-pushed
the
add-newline-action
branch
from
August 25, 2019 14:05
675cc1e
to
5b1a03c
Compare
akshatkarani
force-pushed
the
add-newline-action
branch
3 times, most recently
from
September 4, 2019 07:01
24f27bc
to
d9a5df2
Compare
akshatkarani
force-pushed
the
add-newline-action
branch
2 times, most recently
from
September 8, 2019 05:06
bc41a68
to
892e753
Compare
This extends the commit over coala#2975 and uses a compatible version of codecov to be able to upload report to s3.
This updates the bandit version to fix the dependency issue and to fix coala installation. Closes coala#2985
This adds a new action for GitCommitBear. When applied it opens up a editor for user to edit commit message of the HEAD commit. This also makes changes is CommitBear.py to pass EditCommitMessageAction when Result is yielded.
This adds a new action which adds a newline between shortlog and body of commit message when applied. This also make changes in CommitBear.py to pass AddNewlineAction when Result is yielded.
akshatkarani
force-pushed
the
add-newline-action
branch
from
March 26, 2021 14:25
892e753
to
7ffaabe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes actions list as a argument when yielding a
Result when there is no new line between shortlog and
body of the commit message.