Added missing JsonAssetLoader implementation #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mauriziopinotti JsonAssetLoader implemented in easy_localization package |
|
@Overman775 shouldn't it be here along with all others loaders? |
|
Please merge it! |
aissat
approved these changes
Feb 16, 2021
mauriziopinotti
force-pushed
the
master
branch
2 times, most recently
from
5eedd06 to
77049df
Compare
|
@aissat @Overman775 I updated the pull request with latest code from master and added checks for null-safety to JsonAssetLoader, now the pull request has no conflicts and should be ready to merge. |
|
@aissat @Overman775 ping |
Hi bro sorry I'll check it, I was very busy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I just added the missing implementation of JsonAssetLoader and JsonSingleAssetLoader, freely inspired by YamlAssetLoader.