Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-coassemble contribution from topefolorunso #45669

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

topefolorunso
Copy link
Collaborator

@topefolorunso topefolorunso commented Sep 19, 2024

What

This PR adds a new connector for source Coassemble (source-coassemble).

Contributor-provided connector description:

Coassemble is an online training tool that connects people with the information they need - anytime, anyplace.

Details

Expand for list of spec properties and streams

Configuration

Input Type Description Default Value
user_token string User Token.
user_id string User ID.

Streams

Stream Name Primary Key Pagination Supports Full Sync Supports Incremental
courses id DefaultPaginator

Reviewer checklist

  • Run /format-fix to resolve any formatting errors
  • Help the contributor upload an icon that follows our icon design guidelines
  • Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 10:54pm

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Sep 19, 2024

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topefolorunso PRs have todo-lists now! Check off items you've done already.

If it does not apply any formatting changes, that usually means that you'd need to merge a fresh master in first.

Everything that is in looks good, but I would love to see trackings and screen type streams. Those are "available on request only", so I think this needs a docs entry that enabling them without having them enabled on the API side would result in errors.

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Sep 19, 2024

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@topefolorunso
Copy link
Collaborator Author

topefolorunso commented Sep 19, 2024

but I would love to see trackings and screen type streams. Those are "available on request only", so I think this needs a docs entry that enabling them without having them enabled on the API side would result in errors.

Correct! Do you want me to add the doc now? I think that should come in once the streams are implemented in the connector. @natikgadzhi

@topefolorunso
Copy link
Collaborator Author

PRs have todo-lists now! Check off items you've done already.

@natikgadzhi Please clarify this part "Click into the CI workflows that wait for a maintainer to run them, which should trigger CI runs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/coassemble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants