Destinations cdk: recorddiffer that handles strongly-typed records #44874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
edgao
force-pushed
the
edgao/better_record_differ
branch
4 times, most recently
from
4ed0e22
to
da9d896
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/better_record_differ
branch
from
da9d896
to
7e3fa25
Compare
edgao
changed the base branch from
master
to
issue-9361/load-cdk-with-e2e-dest-post-refactor
edgao
force-pushed
the
edgao/better_record_differ
branch
from
7e3fa25
to
48ca85d
Compare
2 tasks
edgao
force-pushed
the
edgao/better_record_differ
branch
from
48ca85d
to
26b418a
Compare
octavia-squidington-iii
added
area/connectors
edgao
force-pushed
the
edgao/better_record_differ
branch
from
26b418a
to
1930d44
Compare
johnny-schmidt
force-pushed
the
issue-9361/load-cdk-with-e2e-dest-post-refactor
branch
3 times, most recently
from
d43c364
to
26d247c
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
1930d44
to
e0b98f1
Compare
johnny-schmidt
force-pushed
the
issue-9361/load-cdk-with-e2e-dest-post-refactor
branch
from
26d247c
to
e852485
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
e0b98f1
to
0feb717
Compare
johnny-schmidt
force-pushed
the
issue-9361/load-cdk-with-e2e-dest-post-refactor
branch
from
e852485
to
7f0ea41
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
0feb717
to
0432e30
Compare
johnny-schmidt
force-pushed
the
issue-9361/load-cdk-with-e2e-dest-post-refactor
branch
from
7f0ea41
to
ee94dc9
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
0432e30
to
b93f5f1
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
b93f5f1
to
970c3c3
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
970c3c3
to
ce7478f
Compare
This was referenced Sep 16, 2024
edgao
force-pushed
the
edgao/better_record_differ
branch
from
ce7478f
to
baa37fd
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
baa37fd
to
27682cf
Compare
This was referenced Sep 17, 2024
edgao
commented
Sep 17, 2024
| "generationId: Expected ${expectedRecord.generationId}, got ${actualRecord.generationId}\n" | ||
| ) | ||
| } | ||
| if (expectedRecord.airbyteMeta != actualRecord.airbyteMeta) { |
There was a problem hiding this comment.
there's a bug here that I need to fix - airbyteMeta is a JsonNode, which has issues with comparison (IntNode(42) != LongNode(42))
so I need to either make it a real struct, or write something to compare jsonnodes for equality
johnny-schmidt
force-pushed
the
issue-9361/load-cdk-with-e2e-dest-post-refactor
branch
8 times, most recently
from
1260f1f
to
3c769c5
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
27682cf
to
b41f1e4
Compare
edgao
force-pushed
the
issue-9361/load-cdk-with-e2e-dest-post-refactor
branch
from
3c769c5
to
ca834e0
Compare
edgao
force-pushed
the
edgao/better_record_differ
branch
from
b41f1e4
to
f63a834
Compare
johnny-schmidt
approved these changes
Sep 20, 2024
edgao
merged commit f63a834
into
issue-9361/load-cdk-with-e2e-dest-post-refactor
27 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly a copy of the existing RecordDiffer. But this time it operates on OutputRecord + AirbyteValue, which simplifies things by quite a lot. See also #45113 for how this will be used.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/9217