-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(Source-S3): Use dataframe processing in place of singleton record operations (polars) #44194
base: master
Are you sure you want to change the base?
Changes from 64 commits
726a722
faa8517
9fc9cf7
50207aa
392c43b
f8a7b7c
0a00d1e
cec132a
09e8bf7
c78a576
1dab0c4
63a8dc2
2d3031d
a7b1989
e8b4a2d
92733e9
cbb8777
07f7929
d0da02a
87ea175
82568e0
f8093ce
a487c13
3a6305d
77120ab
1ca2ead
a92fa34
feac74a
ed0032b
d1abb84
1e2e657
b8ff8cd
b8c0b11
2b0e986
9eece3f
42ed3ea
6744216
b982e50
1589768
55e1f46
e00857f
1c5b7ea
78a2a99
faa9068
952d90d
209caf7
7112041
644861f
0901763
486fdab
cd5a7dd
d7c7af7
0d80e81
a94187d
015fd90
4cec7a9
60f843c
6a20761
5ebf102
87e43c7
c930f69
b2cd2c5
51d511c
9526835
da92440
b946e43
1919b8d
2bcbc98
6aba77e
5478be1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
venv | ||
.venv | ||
.venv-* | ||
.gradle | ||
.idea | ||
*.iml | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @clnoll, @pnilan - If you have a sec, could you review this file's changes? This works in my testing - the revised/refactored version attempts to handle more edge cases predictably. As discussed, previous to this PR, we were hitting the condition where concurrency was defined (allowing concurrency in full-refresh mode) but the cursor was not concurrent (disabling concurrency in incremental mode). We probably could add a test to check for this, but for now I warn explicitly. I also used the Let me know what you think! Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this will be surfaced to users, it would be nice to give them more information about how to choose. If we dynamically select whether we use bulk mode if a user selects
AUTO
, we should also consider telling them the criteria we're using.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also - if this is only available for jsonl to start it should probably be in the
JsonlFormat
file.