Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/add resource bundle #464

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

Taniya-Das
Copy link
Collaborator

@Taniya-Das Taniya-Das commented Feb 27, 2025

Change

Addition of Resource Bundle in metadata schema.
Uses latest schema shared over email (aiod_model.json) and in #325
Documentation changes will be made in a separate PR (The schema image should be updated to reflect latest changes).

How to Test

Changes are tested using unit test test_router_resource_bundle.py.
If you want to manually test it, follow the usual step to start the docker container /scripts/up.sh

Checklist

  • Tests have been added or updated to reflect the changes, or their absence is explicitly explained.
  • Documentation has been added or updated to reflect the changes, or their absence is explicitly explained.
  • A self-review has been conducted checking:
    • No unintended changes have been committed.
    • The changes in isolation seem reasonable.
    • Anything that may be odd or unintuitive is provided with a GitHub comment explaining it (but consider if this should not be a code comment or in the documentation instead).
  • All CI checks pass before pinging a reviewer, or provide an explanation if they do not.

Related Issues

#325

@Taniya-Das Taniya-Das marked this pull request as ready for review February 27, 2025 22:07
@Taniya-Das Taniya-Das requested a review from PGijsbers February 27, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant