Share common definitions in Review and ReviewCreate #462
+47
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Refactor class hierarchy to allow Review and ReviewCreate share common definitions, s.t. we only need to define examples or limits once.
Also limit the maximum length of review to
LONG
(1800 chars).I think that should be enough for most asset reviews, and it's easier to expand the limit than to shrink it.
How to Test
Changes are under unit test. Affected endpoints is
RESOURCE/review/v1/
if you want to manually test or inspect updated documentation.Checklist
Related Issues