Feat/reviewqueue

[PGijsbers]

Change

Adds convenience functions for reviewers through a review router.
Reviewers can use its endpoints to either get a list of pending submission, or get a specific one.

In a follow up PR we will add conveniences for the user (getting review status for assets, let them read review notes)

How to Test

If your keycloak instance lacks a reviewer account, make sure to recreate your kc:

./scripts/down.sh
./scripts/clean.sh
./scripts/up.sh

Keycloak then has both the regular user, as well as a reviewer user (username: reviewer, password: password).
You can submit a new asset for review as a regular user, and check, approve or reject the submission as a reviewer, and use the new endpoints to get insight into the pending/completed reviews.

Checklist

• Tests have been added or updated to reflect the changes, or their absence is explicitly explained.
• Documentation has been added or updated to reflect the changes, or their absence is explicitly explained.
• A self-review has been conducted checking:
  • No unintended changes have been committed.
  • The changes in isolation seem reasonable.
  • Anything that may be odd or unintuitive is provided with a GitHub comment explaining it (but consider if this should not be a code comment or in the documentation instead).
• All CI checks pass before pinging a reviewer, or provide an explanation if they do not.

Related Issues

[PGijsbers]

Indicates that the field will not be serialized to JSON, which is to say it will not be shown to end users.

[Taniya-Das]

Looks good.
Does it make sense to add the review decision and comment in the submission list, so that reviewer can see the details of the completed reviews?

[PGijsbers]

Good idea! Turned it into a separate issue so we can follow up separately :)