Update/sponge 8 fix #421
Open
Update/sponge 8 fix #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/main/java/co/aikar/commands/CommandManager.java
|
I am concerned about the removal of the removal of constructors for SpongeCommandSource. Admittedly, I have no way to know if anyone is or isn't using it. But if I simply merge and deploy this to the current version of ACF - it has the technical potential to break if for some reason someone had called that API. I am aware that within the ACF module - it doesn't have an affect, but would prefer to find a solution which keeps constructors where possible with a Deprecated or something. |
|
I should say. I am not necessarily opposed to merging it as proposed. Just want the before mentioned risk be part of the conversation. |
…y store Locale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows compatibility for sponge8 till sponge 10 (tested at least) and is more flexible towards sponge api breakages.
Requires testing (will test in a few days or when am free, or someone else ig).