A CodeQL library for Kaleidoscope #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Oct 10, 2023
ql/lib/codeql/kaleidoscope/Ast.qll
Outdated
| override Location getLocation() { result = node.getLocation() } | ||
| } | ||
|
|
||
| class ParenExpression extends Expression, TParenExpression { |
There was a problem hiding this comment.
Did you consider using the synthesis/desugaring framework for desugaring away parentheses?
There was a problem hiding this comment.
That felt a bit overkill .
Comment on lines
+11
to
+16
| this = | ||
| any(BinaryOpExpression e | | ||
| e.getOperator().getName() = "=" and | ||
| variable = e.getLhs().(VariableExpression).getVariable() | ||
| ) or | ||
| variable = this.(Initializer).getVariable() |
There was a problem hiding this comment.
Perhaps have another field rhs, to avoid duplicating this pattern in getValue.
There was a problem hiding this comment.
The rhs is optional in a variable declaration (Initializer) in which case it defaults to 0.0.
Update link in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.