Migrate Travis CI to Github Actions #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetb
reviewed
Nov 21, 2021
.github/workflows/test.yml
Outdated
| # events but only for the master branch | ||
| on: | ||
| pull_request: | ||
| branches: |
There was a problem hiding this comment.
Branches: is probably not necessary
ahmetb
reviewed
Nov 21, 2021
.github/workflows/test.yml
Outdated
| - name: Setup Go | ||
| uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: '1.11' # The Go version to download (if necessary) and use. |
There was a problem hiding this comment.
I've used this to install tip, there is no easy way to get tip version directly.
actions/setup-go#21
ahmetb
reviewed
Nov 21, 2021
.github/workflows/test.yml
Outdated
| # Run vet & lint on the code | ||
| - name: Run vet & lint | ||
| run: | | ||
| go vet -x ./... |
There was a problem hiding this comment.
Ideally these should be separate steps
There was a problem hiding this comment.
Because you don’t set -e, any failure won’t terminate the script
ahmetb
reviewed
Nov 21, 2021
| - name: Run tests | ||
| run: | | ||
| go test -v ./... | ||
| go test -covermode=count -coverprofile=profile.cov |
There was a problem hiding this comment.
Not all these are tests + ideally should be separate steps
Update Github Action Test GH Action Test GH Action Update GH Action Update GH Action Update GH Action Update GH Action Update GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Test GH Action Update GH Action Update GH Action Update GH Action Update GH Action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "tip" is really necessary I can update the action.
Sample Pull Request check: berabulut#1