Skip to content

[Import] Codata.* #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 8, 2025
Merged

[Import] Codata.* #2616

merged 5 commits into from
Mar 8, 2025

Conversation

jmougeot
Copy link
Contributor

No description provided.

Copy link
Contributor

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (but again, need to wait for CI)

@jamesmckinna
Copy link
Contributor

jamesmckinna commented Feb 26, 2025

See my comment on #2617 about Codata.Musical.Notation.

UPDATED: I guess after looking again at that merged PR, that I now accept, albeit reluctantly, the explicit mention of the 'musical' notation. I think that it might be useful separately, perhaps under #2339 , to discuss whether it is a good idea or not to explicit expose the API of a given import in this way, in terms of knock-on viscosity (but I take the spirit of @JacquesCarette 's intentions, and @jmougeot 's implementations in this series of PRs, to be: yes, it's worth the cost, because this is a way of seeing upfront what has to be paid, rather than having to search for it, or be taken by surprise by it, later)

@jmougeot jmougeot changed the title Import Cleaning Codata [Import] Codata Feb 26, 2025
@jmougeot jmougeot changed the title [Import] Codata [Import] Codata.* Feb 26, 2025
Copy link
Contributor

@jamesmckinna jamesmckinna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given all this activity in 'regularising' the role of imports with using directives, standardising the order of names mentioned (type before constructors, constructors before functions, functions before relations, or simply 'module dependency order'?) seems a good idea?

Copy link
Contributor

@jamesmckinna jamesmckinna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to merge!

@jamesmckinna jamesmckinna enabled auto-merge March 8, 2025 16:27
@jamesmckinna jamesmckinna added this pull request to the merge queue Mar 8, 2025
Merged via the queue into agda:master with commit 87bede7 Mar 8, 2025
2 checks passed
jamesmckinna added a commit to jamesmckinna/agda-stdlib that referenced this pull request Mar 17, 2025
* Import Cleaning Codata

* bug fixed

* bug fixed

* Update src/Codata/Musical/Colist/Bisimilarity.agda

Ordering

* Update src/Codata/Musical/Colist/Properties.agda

Ordering

---------

Co-authored-by: jamesmckinna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants