Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutable objects as default parameter values in a function #946

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

davorrunje
Copy link
Collaborator

Why are these changes needed?

Related issue number

Checks

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
3.10 59.64% <ø> (-0.04%) ⬇️
3.11 57.08% <ø> (-1.46%) ⬇️
3.12 54.38% <ø> (-0.04%) ⬇️
3.13 59.10% <ø> (-0.07%) ⬇️
3.9 58.79% <ø> (-7.22%) ⬇️
anthropic 15.57% <ø> (-21.47%) ⬇️
autobuild ?
bedrock 15.92% <ø> (-0.02%) ⬇️
browser-use 29.65% <ø> (-4.36%) ⬇️
cerebras 15.65% <ø> (-0.02%) ⬇️
cohere 15.69% <ø> (-0.02%) ⬇️
commsagent-discord 30.03% <ø> (-0.02%) ⬇️
commsagent-slack 30.01% <ø> (-0.02%) ⬇️
commsagent-telegram 29.96% <ø> (-0.02%) ⬇️
crawl4ai 29.74% <ø> (-3.57%) ⬇️
deepseek ?
docs 28.74% <ø> (-0.01%) ⬇️
falkordb ?
gemini 15.67% <ø> (-23.21%) ⬇️
graph-rag-falkor-db 28.22% <ø> (-0.01%) ⬇️
groq 15.67% <ø> (-0.02%) ⬇️
interop 29.60% <ø> (-4.01%) ⬇️
jupyter-executor 30.80% <ø> (-0.02%) ⬇️
lmm 18.37% <ø> (-0.49%) ⬇️
long-context 14.85% <ø> (-0.02%) ⬇️
macos-latest 60.09% <ø> (-0.04%) ⬇️
mistral 15.39% <ø> (-0.02%) ⬇️
neo4j ?
ollama 16.05% <ø> (-0.02%) ⬇️
openai ?
retrievechat 29.72% <ø> (-0.02%) ⬇️
retrievechat-mongodb 29.71% <ø> (-0.02%) ⬇️
retrievechat-pgvector 29.71% <ø> (-0.02%) ⬇️
retrievechat-qdrant 29.66% <ø> (-0.02%) ⬇️
teachable 15.02% <ø> (-2.83%) ⬇️
together 15.70% <ø> (-0.02%) ⬇️
twilio 28.43% <ø> (-0.01%) ⬇️
ubuntu-latest 60.12% <ø> (-7.74%) ⬇️
websurfer 17.80% <ø> (-0.02%) ⬇️
windows-latest 57.87% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

@davorrunje davorrunje added this pull request to the merge queue Feb 13, 2025
@Eric-Shang
Copy link
Collaborator

Sorry I was not very mindful of the bad habit.

Merged via the queue into main with commit 27b3749 Feb 13, 2025
334 of 341 checks passed
@davorrunje davorrunje deleted the polishing branch February 13, 2025 22:00
AgentGenie pushed a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants