Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG-13345: Last label on axis gets clipped #3436

Merged
merged 12 commits into from
Feb 6, 2025
Merged

Conversation

iMoses
Copy link
Contributor

@iMoses iMoses commented Jan 29, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
+ minor cleanups
@iMoses iMoses requested a review from alantreadway as a code owner January 29, 2025 10:38
@iMoses iMoses changed the title AG-13345: Last label on time axis gets clipped AG-13345: Last label on axis gets clipped Jan 29, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
# Conflicts:
#	packages/ag-charts-community/src/chart/axis/axis.ts
#	packages/ag-charts-community/src/module/axisContext.ts
#	packages/ag-charts-enterprise/src/features/annotations/__image_snapshots__/annotations-test-ts-annotations-initial-should-render-a-vertical-cross-line-annotation-1-snap.png
#	packages/ag-charts-enterprise/src/features/annotations/__image_snapshots__/annotations-test-ts-annotations-lines-with-text-should-render-stacked-annotations-with-text-1-snap.png
#	packages/ag-charts-enterprise/src/features/annotations/__image_snapshots__/annotations-test-ts-annotations-lines-with-text-should-render-vertical-line-annotations-with-text-1-snap.png

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iMoses and others added 8 commits February 5, 2025 15:58
# Conflicts:
#	packages/ag-charts-enterprise/src/features/data-source/__image_snapshots__/data-source-test-ts-data-source-with-window-should-change-the-window-after-a-change-in-zoom-2-snap.png
#	packages/ag-charts-enterprise/src/features/data-source/__image_snapshots__/data-source-test-ts-data-source-with-window-should-load-a-window-at-the-end-1-snap.png
#	packages/ag-charts-enterprise/src/features/data-source/__image_snapshots__/data-source-test-ts-data-source-with-window-should-load-a-window-in-the-middle-1-snap.png
#	packages/ag-charts-enterprise/src/features/navigator/__image_snapshots__/navigator-test-ts-navigator-create-for-nav-zoomed-clipped-crosslines-1-it-should-render-to-canvas-as-expected-1-snap.png
#	packages/ag-charts-enterprise/src/features/navigator/__image_snapshots__/navigator-test-ts-navigator-create-for-nav-zoomed-clipped-crosslines-2-it-should-render-to-canvas-as-expected-1-snap.png
…13345

# Conflicts:
#	packages/ag-charts-enterprise/src/features/data-source/__image_snapshots__/data-source-test-ts-data-source-with-window-should-change-the-window-after-a-change-in-zoom-2-snap.png
#	packages/ag-charts-enterprise/src/features/data-source/__image_snapshots__/data-source-test-ts-data-source-with-window-should-load-a-window-at-the-end-1-snap.png
#	packages/ag-charts-enterprise/src/features/data-source/__image_snapshots__/data-source-test-ts-data-source-with-window-should-load-a-window-in-the-middle-1-snap.png
#	packages/ag-charts-enterprise/src/features/navigator/__image_snapshots__/navigator-test-ts-navigator-create-for-nav-zoomed-clipped-crosslines-1-it-should-render-to-canvas-as-expected-1-snap.png
#	packages/ag-charts-enterprise/src/features/navigator/__image_snapshots__/navigator-test-ts-navigator-create-for-nav-zoomed-clipped-crosslines-2-it-should-render-to-canvas-as-expected-1-snap.png
Copy link
Member

@alantreadway alantreadway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alantreadway alantreadway merged commit 106556f into latest Feb 6, 2025
26 checks passed
@alantreadway alantreadway deleted the imoses/ag-13345 branch February 6, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants